Skip to content

Commit 435f8fe

Browse files
committed
fix: pin mkdocs-material version, scope docs.yaml permissions, annotate cache key hashing
- Pin mkdocs-material==9.7.6 in docs.yaml and ci.yaml (Scorecard Pinned-Dependencies alert #1) - Move pages/id-token write permissions to deploy job in docs.yaml - Add nolint annotations on SHA256 cache key derivation (not password storage); CodeQL alerts #10 and #11 dismissed as false positives Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
1 parent f42e7b6 commit 435f8fe

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ jobs:
158158
- name: Install MkDocs
159159
shell: bash -Eeuo pipefail {0}
160160
run: |
161-
python3 -m pip install --user --break-system-packages mkdocs-material
161+
python3 -m pip install --user --break-system-packages mkdocs-material==9.7.6
162162
echo "$(python3 -m site --user-base)/bin" >> "$GITHUB_PATH"
163163
164164
- name: Build docs site

.github/workflows/docs.yaml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@ on:
1212

1313
permissions:
1414
contents: read
15-
pages: write
16-
id-token: write
1715

1816
concurrency:
1917
group: docs
@@ -29,7 +27,7 @@ jobs:
2927

3028
- name: Install MkDocs
3129
run: |
32-
python3 -m pip install --user --break-system-packages mkdocs-material
30+
python3 -m pip install --user --break-system-packages mkdocs-material==9.7.6
3331
echo "$(python3 -m site --user-base)/bin" >> "$GITHUB_PATH"
3432
3533
- name: Build site
@@ -45,6 +43,9 @@ jobs:
4543
needs: build
4644
runs-on: ${{ vars.RUNNER || 'ubuntu-latest' }}
4745
timeout-minutes: 5
46+
permissions:
47+
pages: write
48+
id-token: write
4849
environment:
4950
name: github-pages
5051
url: ${{ steps.deployment.outputs.page_url }}

0 commit comments

Comments
 (0)