fix(e2e): resolve recommend-mode Chainsaw intermittent timeout (#92)

* fix(e2e): resolve recommend-mode Chainsaw intermittent timeout

The verify-status step asserted Ready=False/InsufficientData, a transient
state the operator passes through before collecting Prometheus data. With
minimumDataPoints=1 and a 15s scrape interval, the operator can transition
to Ready=True/Monitoring within seconds, causing the static assert to
timeout waiting for a condition that already passed.

Replace the static assert with a script-based poll that accepts either
InsufficientData or Monitoring as valid states. Add a verify-no-resizes
step to confirm Recommend mode does not apply changes.

Closes #87

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

* fix(ci): add issues:write permission and single API call for pr-size labels

The pr-size workflow failed with HTTP 401 on gh pr edit --add-label
because label management uses the Issues API, which needs issues:write
permission (not just pull-requests:write). Also replaced 6 sequential
gh pr edit calls with a single REST API PUT that fetches current labels,
filters out size/* labels, and sets the new one in one call.

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

---------

Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>

Author: SebTardif

.github/workflows/pr-size.yaml

@@ -6,6 +6,7 @@ on:
 permissions:
   contents: read
   pull-requests: write
+  issues: write
 
 jobs:
   size-label:
@@ -43,11 +44,13 @@ jobs:
 
           echo "PR #${PR_NUMBER}: +${ADDITIONS} -${DELETIONS} = ${TOTAL} lines -> ${SIZE}"
 
-          # Remove any existing size labels, then add the correct one
-          for label in size/xs size/s size/m size/l size/xl; do
-            gh pr edit "$PR_NUMBER" --repo "${{ github.repository }}" --remove-label "$label" 2>/dev/null || true
-          done
-          gh pr edit "$PR_NUMBER" --repo "${{ github.repository }}" --add-label "$SIZE"
+          # Fetch current labels, swap the size/* label in one API call
+          REPO="${{ github.repository }}"
+          KEEP=$(gh api "repos/${REPO}/issues/${PR_NUMBER}" --jq \
+            '[.labels[].name | select(startswith("size/") | not)]')
+          FINAL=$(echo "$KEEP" | jq --arg s "$SIZE" '. + [$s]')
+          echo "$FINAL" | jq '{labels: .}' | \
+            gh api "repos/${REPO}/issues/${PR_NUMBER}/labels" --method PUT --input -
 
           # Post a warning comment for XL PRs
           if [ "$SIZE" = "size/xl" ]; then

test/e2e/recommend-mode/chainsaw-test.yaml

@@ -94,6 +94,32 @@ spec:
               status:
                 readyReplicas: 1
     - name: verify-status
+      try:
+        - script:
+            timeout: 3m
+            content: |
+              # The operator may transition quickly from InsufficientData to Monitoring
+              # when minimumDataPoints is 1 and Prometheus scrapes fast. Accept either
+              # state as valid — both prove the policy discovered the workload and
+              # the controller reconciled it.
+              for i in $(seq 1 36); do
+                reason=$(kubectl get attunepolicy recommend-test -n e2e-recommend-mode \
+                  -o jsonpath='{.status.conditions[?(@.type=="Ready")].reason}' 2>/dev/null)
+                discovered=$(kubectl get attunepolicy recommend-test -n e2e-recommend-mode \
+                  -o jsonpath='{.status.workloads.discovered}' 2>/dev/null)
+                if [ "$discovered" = "1" ]; then
+                  if [ "$reason" = "InsufficientData" ] || [ "$reason" = "Monitoring" ]; then
+                    echo "OK: workloads discovered=$discovered, Ready reason=$reason"
+                    exit 0
+                  fi
+                fi
+                echo "Waiting... discovered=$discovered reason=$reason"
+                sleep 5
+              done
+              echo "FAIL: timed out waiting for policy to discover workloads"
+              kubectl get attunepolicy recommend-test -n e2e-recommend-mode -o yaml
+              exit 1
+    - name: verify-no-resizes
       try:
         - assert:
             resource:
@@ -103,10 +129,8 @@ spec:
                 name: recommend-test
                 namespace: e2e-recommend-mode
               status:
-                conditions:
-                  - type: Ready
-                    status: "False"
-                    reason: InsufficientData
+                workloads:
+                  resized: 0
   catch:
     - describe:
         apiVersion: attune.io/v1alpha1