Skip to content

Scorecard: Enable branch protection for code review enforcement #81

Description

@SebTardif

Scorecard Alert

Check: Code-Review (alert #6)
Score: 0/10

Problem

Scorecard found 0 out of 23 approved changesets. This means PRs are being merged without formal GitHub review approvals. The check looks for GitHub review approvals on merged PRs, not informal review.

Root Cause

As a new single-maintainer project, PRs are self-merged without requesting a review from another GitHub account. Scorecard counts only PRs with at least one APPROVED review.

Options

Option A: Require PR reviews (recommended for maturity)

  1. Go to Settings > Rules > Rulesets (or branch protection)
  2. Add a rule for main:
    • Require a pull request before merging
    • Require approvals: 1
  3. Use a second maintainer account or add a collaborator for reviews

Option B: Self-approve with a bot or second account

  • Less ideal but satisfies the Scorecard check mechanically

Option C: Accept the score

  • For a single-maintainer project, this score is expected
  • The score improves naturally when collaborators join

Context

This is a process/governance improvement, not a technical fix. The score will improve organically as the project gains contributors who review each other's PRs. Consider enabling review requirements when a second regular contributor joins.

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    securitySecurity improvements and hardeningtech-debtTechnical debt to address

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions