In fish with `inline_height` set, the prompt line is intersected by the first line of atuin

[rmartine-ias]

Describe the bug

See below how the green r in ^rmartine and the r in master remain onscreen in the first line of the atuin dialog:

This does not happen for me in zsh. It is not too bad unless I also disable the help bar, then it is much more prominent.

Confirmed this happens in Terminal.app, with starship prompt disabled, outside of tmux, with all custom fish config (config.fish/conf.d) disabled.

To Reproduce
Steps to reproduce the behavior:

1. Install fish, add atuin
2. Set inline_height to be less than the height of the terminal
3. Press up-arrow or ctrl-r

Expected behavior
Prompt line to not be intersected, the same as zsh.

Error logs
Please try and provide error logs where possible

Device (please complete the following information):

• OS: MacOS
• Shell: fish, version 3.6.1-679-g63b23713f
• Version: atuin 16.0.0

[conradludgate]

Thanks for the report, I'll see if I can reproduce it

[arcuru]

I can repro this as well. It also isn't clearing everything from the top line, so anywhere that Atuin paints whitespace are still present when Atuin is up, you can see that in the image above.

To be honest, I'd actually prefer this if it properly cleared existing characters, since I use invert = true. It doesn't move the position of my input and just gives a dropdown list of choices. But this should still probably be fixed.

[Lillecarl]

diff --git a/atuin/src/command/client/search/interactive.rs b/atuin/src/command/client/search/interactive.rs
index 8ae03752..bff1c872 100644
--- a/atuin/src/command/client/search/interactive.rs
+++ b/atuin/src/command/client/search/interactive.rs
@@ -490,7 +490,8 @@ impl State {
         let mode_width = MAX_WIDTH - pref.len();
         // sanity check to ensure we don't exceed the layout limits
         debug_assert!(mode_width >= mode.len(), "mode name '{mode}' is too long!");
-        let input = format!("[{pref}{mode:^mode_width$}] {}", self.search.input.as_str(),);
+        let input = format!("[{pref}{mode:^mode_width$}]").replace(" ", "\u{a0}");
+        let input = format!("{input} {}", self.search.input.as_str());
         let input = Paragraph::new(input);
         if style.compact {
             input

https://asciinema.org/a/gzgzolH2QtPtCNv6CgcnQyV3h

This is my first ever contribution to a Rust project (just had the LSP installed the other day), so take it with a pinch of salt. What it does is it replaces the space character with a non-breaking space character, which fish with the repaint thingy will redraw.

There's still an extra square bracket on the left, not the end of the world. But while we're at it it might be something worth looking into (I have to go to bed)

EDIT: My issue is a reproduction and fix for the problem @arcuru, but anywhere atuin is writing spaces they should probably be replaced by nbsp instead. See https://en.wikipedia.org/wiki/Whitespace_character

EDIT2: This seems like a fish-shell bug. They're also mostly written in Rust now so people here might have an easy time understanding the codebase. The current release is the last before they're "100% Rust" 😄 I'll open an issue tomorrow

[nounder]

I'm also experiencing the same issue:

[mattrobenolt]

This happens to me as well with the following:

$ fish --version
fish, version 4.0b1
$ atuin --version
atuin 18.4.0
$ cat ~/.config/atuin/config.toml | rg inline_height
inline_height = 20

For comparison in zsh, exact same prompt from starship and same atuin config, it correctly renders down 1 line below my prompt:

[fzakaria]

I am running NixOS so I must be on an older fish.

NixOS 24.11
fish, version 3.7.1

{
  "atuin": {
    "version": "18.4.0",
    "sync": {
      "cloud": true,
      "records": true,
      "auto_sync": true,
      "last_sync": "2025-02-17 18:41:23.437921056 +00:00:00"
    },
    "sqlite_version": "3.46.0"
  },
  "shell": {
    "name": "fish",
    "default": "bash",
    "plugins": [
      "atuin"
    ],
    "preexec": "built-in"
  },
  "system": {
    "os": "NixOS",
    "arch": "x86_64",
    "version": "24.11",
    "disks": [
      {
        "name": "/dev/disk/by-label/nixos",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/disk/by-label/nixos",
        "filesystem": "ext4"
      },
      {
        "name": "/dev/nvme0n1p3",
        "filesystem": "vfat"
      }
    ]
  }
}

[phanen]

Workaround (related: fish-shell/fish-shell#11160)

bind ctrl-r \
    'functions -c fish_prompt __fish_prompt_save' \
    'function fish_prompt; end' \
    'set -g __atuin_commandline (commandline)' \
    'set -g __atuin_cursor_line (commandline -L)' \
    'set -g __atuin_cursor_column (commandline -C)' \
    'commandline -r ""' \
    repaint \
    atuin_search \
    'functions -e fish_prompt' \
    'functions -c __fish_prompt_save fish_prompt' \
    'functions -e __fish_prompt_save' \
    # 'commandline -r $__atuin_commandline' \
    # 'set -e __atuin_commandline' \
    # 'commandline -L $__atuin_cursor_line' \
    # 'set -e __atuin_cursor_line' \
    # 'commandline -C $__atuin_cursor_column' \
    # 'set -e __atuin_cursor_column' \
    repaint

[fzakaria]

is this something that should be included in atuin directly or is it a fish bug?

[phanen]

Just test a bit. Not only fish:
nushell, xonsh also have this intersection problem when use inline-height.
And even zsh... current implementation start in a new line so feel acceptable.

But to really make it work well, all shell need to do similar stuffs like:

1. save current prompt, cursor position, cmdline...
2. clear the prompt, cmdline...
3. atuin search -i...
4. restore prompt, cursor, cmdline

If atuin don't correctly clear prompt/cmdline, shell always need to do 1-4. (for fish, it looks hacky to do all these thing correctly, but that's how it currently work... Maybe upstream can figure out a more native function implementation for bindings...)

If atuin can override/clear the prompt correctly in core, then all shell need to do is basically a redraw?

And shell integrations should focus on more meaningful thing, rather than do these tedious hack. e.g. for fish: cmd xxx | cmd yyy, when cursor on yyy, we can ctrl-r to search and replace cmd yyy with history content (or more fine-grained scopes like job, process, token...)

[ltrzesniewski]

I added the following in #2543 because I noticed this problem:

https://github.com/ltrzesniewski/atuin/blob/21bb83ae489ab3e1ba56326c61f58460b086e191/crates/atuin/src/command/client/search/interactive.rs#L1105-L1107

It fixes the issue for me but should also work for other shells.

[fzakaria]

I added the following in #2543 because I noticed this problem:

https://github.com/ltrzesniewski/atuin/blob/21bb83ae489ab3e1ba56326c61f58460b086e191/crates/atuin/src/command/client/search/interactive.rs#L1105-L1107

It fixes the issue for me but should also work for other shells.

I haven't tried your patch yet but wouldn't a full clear defeat the purpose of having inline height less than the full terminal? (The point would be to keep the precious entries?)

[ltrzesniewski]

It's not obvious from the name of the function, but this only clears the part of the screen where the inline terminal will appear.