-
Notifications
You must be signed in to change notification settings - Fork 129
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Is your feature request related to a problem? Please describe.
It seems there are devices that cannot be configured for LEFT channel (like M5StickC), and sometimes it would be interesting to change to LEFT or RIGHT channel without needing a special firmware for each channel.
Describe the solution you'd like
- Additional drop-down in sound input settings: LEFT, RIGHT
- Changes will need a restart (because I2S driver is only configured at startup)
- simple solution with minimal code changes
Describe alternatives you've considered
it would also be possible to always request left+right channel from I2S, and do a down-mix in software. However this has some drawbacks:
- loss of volume - especially when one channels is silent then left+right / 2 = 0.5 left
- doubles the buffer needed to store I2S samples, even when only one channel contains audio
- i2s internal samples queues would also be doubled
- Usually music is playing on both channels, so there will not be much difference (for SRWLED) compared to only using one channel.
Additional context
There is already the possibility for users to self-compile SRWLED for using I2S right channel:
build_flags = -D I2S_USE_RIGHT_CHANNEL
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request