Skip to content

Commit 0c6eb85

Browse files
authored
Merge pull request #2 from audrasjb/fix-enqueue-only-when-necessary
Let's enqueue scripts and styles only when a shortcode/widget is present in the current page. Props @juliobox
2 parents 0fdbca8 + f57c90c commit 0c6eb85

3 files changed

Lines changed: 26 additions & 18 deletions

File tree

public/public.php

Lines changed: 14 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,21 +11,18 @@
1111
* @prefix gdrf_
1212
*/
1313

14-
add_action( 'wp_enqueue_scripts', 'enqueue_styles_gdrf_public' );
15-
function enqueue_styles_gdrf_public() {
16-
wp_enqueue_style( 'gdrf-public-styles', plugin_dir_url( __FILE__ ) . 'css/public.css', array(), '', 'all' );
17-
}
14+
add_action( 'wp_enqueue_scripts', 'enqueue_styles_gdrf_public' );
15+
function enqueue_styles_gdrf_public() {
16+
wp_register_style( 'gdrf-public-styles', plugin_dir_url( __FILE__ ) . 'css/public.css', array(), '', 'all' );
17+
}
1818

19-
add_action( 'wp_enqueue_scripts', 'enqueue_scripts_gdrf_public' );
20-
function enqueue_scripts_gdrf_public() {
21-
wp_register_script( 'gdrf-public-scripts', plugin_dir_url( __FILE__ ) . 'js/gdrf-public.js', array( 'jquery' ), '', false );
22-
$translations = array(
23-
'gdrf_ajax_url' => esc_url( admin_url( 'admin-ajax.php' ) ),
24-
'gdrf_success' => __( 'Your enquiry have been submitted. Check your email to validate your data request.', 'gdpr-data-request-form' ),
25-
'gdrf_errors' => __( 'Some errors occurred:', 'gdpr-data-request-form' ),
26-
);
27-
wp_localize_script( 'gdrf-public-scripts', 'gdrf_localize', $translations );
28-
wp_enqueue_script( 'gdrf-public-scripts' );
29-
}
30-
31-
19+
add_action( 'wp_enqueue_scripts', 'enqueue_scripts_gdrf_public' );
20+
function enqueue_scripts_gdrf_public() {
21+
wp_register_script( 'gdrf-public-scripts', plugin_dir_url( __FILE__ ) . 'js/gdrf-public.js', array( 'jquery' ), '', false );
22+
$translations = array(
23+
'gdrf_ajax_url' => esc_url( admin_url( 'admin-ajax.php' ) ),
24+
'gdrf_success' => __( 'Your enquiry have been submitted. Check your email to validate your data request.', 'gdpr-data-request-form' ),
25+
'gdrf_errors' => __( 'Some errors occurred:', 'gdpr-data-request-form' ),
26+
);
27+
wp_localize_script( 'gdrf-public-scripts', 'gdrf_localize', $translations );
28+
}

public/shortcode.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,12 @@
1313

1414
function gdrf_shortcode_init() {
1515
function gdrf_shortcode_data_request( $atts ) {
16+
17+
// Enqueue CSS/JS
18+
wp_enqueue_script( 'gdrf-public-scripts' );
19+
wp_enqueue_style( 'gdrf-public-styles' );
20+
21+
// Display the form
1622
ob_start();
1723
?>
1824
<form action="<?php echo esc_url( admin_url( 'admin-ajax.php' ) ); ?>" method="post" id="gdrf-form">

public/widget.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,12 @@ function __construct() {
2727
}
2828

2929
public function widget( $args, $instance ) {
30-
30+
31+
// Enqueue CSS/JS
32+
wp_enqueue_script( 'gdrf-public-scripts' );
33+
wp_enqueue_style( 'gdrf-public-styles' );
34+
35+
// Display the form
3136
?>
3237
<form action="<?php echo esc_url( admin_url( 'admin-ajax.php' ) ); ?>" method="post" id="gdrf-form" class="widget widget_gdrf">
3338
<input type="hidden" name="action" value="gdrf_data_request">

0 commit comments

Comments
 (0)