bug: fix getSeasons for during and season_name queries, add tests for during

Author: aureateAnatidae

apps/backend/src/v1/season/service.ts

@@ -16,10 +16,10 @@ export async function getSeasons(
         query.where({ season_id });
     }
     if (season_name) {
-        query.whereILike(season_name, "%season_name%");
+        query.whereILike(season_name, `%{season_name}%`);
     }
     if (during) {
-        query.where("end_at", "<=", during).where("start_at", "<=", during);
+        query.where("end_at", ">=", during).where("start_at", "<=", during);
     }
     return await query;
 }

apps/backend/src/v1/season/test/integration.test.ts

@@ -44,12 +44,20 @@ describe("Season table operations", () => {
     });
     describe("Use `getSeasons`", () => {
         test("Typical", async () => {
+            const past_season = pastSeasonRecordFactory();
+            const current_season = currentSeasonRecordFactory();
+            const future_season = futureSeasonRecordFactory();
             await seed_db(
-                new TestSeedSource({ season_records: [currentSeasonRecordFactory()] }),
+                new TestSeedSource({
+                    season_records: [past_season, current_season, future_season],
+                }),
                 test_knexDb,
             );
-            const result = await getSeasons({ during: Date() }, test_knexDb);
-            console.log(result);
+
+            const result = await getSeasons({ during: (new Date()).toISOString() }, test_knexDb);
+
+            expect(result).toHaveLength(1);
+            expect(result[0]).toMatchObject(current_season);
 
             // const match_id = await createMatch(mockMatchReport.guild_id, test_knexDb);
             // const created_match = await test_knexDb("Match")