Skip to content

Styles & history & copy-pasting: refactor #415

@aurelienpierre

Description

@aurelienpierre

That code is unmaintainable, slow, does many redundant operations, and most of it is not thread-safe.

  • don't write history immediately back when reading it 0eb29af
  • cleanup redundant undo/redo commits to stack d1ae32b
  • move xmp writing to a separate thread to prevent filesystem & network I∕O from blocking UI 2d717f8cd5e6ef901c61ab1429048d40176e1f0b
  • auto-save history in background while in darkroom
  • remove GUI code from dt_dev_history_[add/read/pop]_ext()
  • refactor dt_dev_history_[add/read/pop]_ext() to something understandable
  • clean up high-level history copy and paste, add debug strings
  • clean up high-level styles, add debug strings
  • refactor the 3 different methods that write XMP
  • add copy-pasting option to mandatorily create new modules in target pipeline/history
  • add an app-level DB lock on image's history read/write from library
  • don't save histories that didn't change since opening 05ac029
  • update DB history hash when writing histories 8ad5c78

Sub-issues

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs refactoringpriority: highAffects basic and core functionnalities of the software in a way that severly degrades usability

    Type

    No type

    Projects

    Status

    On hold

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions