Skip to content

Automatic tests for new metadata #14

@mfornet

Description

@mfornet

When a new PR is created with the format Add <SYMBOL_OF_YOUR_ERC20_TOKEN> metadata trigger some automatic tests to avoid merging invalid metadata, or invalid format. This will improve significantly workflow for the reviewer.

This is list (potentially non-comprehensive) of required tests for a PR to be approved.

  • Ethereum address must exist
  • Ethereum address must have proper checksum (online tool for this: https://ethsum.netlify.app/)
  • ?Aurora address must exist?
  • ?Aurora address must have proper checksum?
  • name must match metadata from ethereum
  • symbol must match metadata from ethereum
  • decimals must match metadata from ethereum
  • icon data must match svg file
  • icon is a optimized svg as suggested in the standard (in particular it should be less than 8kb)
  • NEP-141 has aurora registered for storage

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions