-
Notifications
You must be signed in to change notification settings - Fork 161
Automatic tests for new metadata #14
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Description
When a new PR is created with the format Add <SYMBOL_OF_YOUR_ERC20_TOKEN> metadata trigger some automatic tests to avoid merging invalid metadata, or invalid format. This will improve significantly workflow for the reviewer.
This is list (potentially non-comprehensive) of required tests for a PR to be approved.
- Ethereum address must exist
- Ethereum address must have proper checksum (online tool for this: https://ethsum.netlify.app/)
- ?Aurora address must exist?
- ?Aurora address must have proper checksum?
-
namemust match metadata from ethereum -
symbolmust match metadata from ethereum -
decimalsmust match metadata from ethereum -
icondata must match svg file -
iconis a optimized svg as suggested in the standard (in particular it should be less than 8kb) - NEP-141 has aurora registered for storage
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers