Commit 131ef59
docs: stop offering an unsupported directory, and split the silence claim
Two claims a review found, both asserting more than the code does.
The unpack doc offered RELDIR and the sasl releases_dir parameter as ways to
name another release directory. rel_dir/0 is Path.join(Deployment.root_dir(),
"releases") and consults neither, so setting one does not merely go unread: it
moves the directory the handler unpacks into and keeps its records in, while
the ERTS guard reading the target .rel (commands.ex:128) and the step writing
the target configuration (commands.ex:743) both still resolve
<root>/releases/<vsn>. The doc was directing operators into an upgrade that
cannot complete. It now says so. AGENTS.md already had this right and cites
issue #23; the omission was only in the public doc.
The moduledoc said the commands that are questions "succeed with nothing to
say at all". releases/0 is a question and prints a line per release through
report!/1, which its own @doc promises, so automation was given the wrong
stdout contract. What gets printed varies by command, not by kind:
upgradable/0 and running/1 return {:ok, []}, releases/0 returns the table.
Co-Authored-By: Claude <noreply@anthropic.com>1 parent 3e8a07d commit 131ef59
1 file changed
Lines changed: 13 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
36 | | - | |
37 | | - | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
337 | 339 | | |
338 | 340 | | |
339 | 341 | | |
340 | | - | |
341 | | - | |
342 | | - | |
343 | | - | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
| 345 | + | |
| 346 | + | |
| 347 | + | |
| 348 | + | |
| 349 | + | |
| 350 | + | |
344 | 351 | | |
345 | 352 | | |
346 | 353 | | |
| |||
0 commit comments