Skip to content

Commit da485dd

Browse files
committed
build: pin Forecastle to feature/upgrade-tooling for the tooling work
The tooling in #32 changes both halves at once - the task rename and the appup coverage check are Forecastle's, the upgrade_from: option is Castle's - so a branch reading the integration branch would build against a Forecastle without them. Goes back to release/1.0.0 when that tree merges, and to {:forecastle, "~> 1.0", runtime: false} before publishing. Nothing enforces either step: the fixture's own pin had to be moved off castle#14's issue branch before that branch was deleted, on the same absence of a check. Refs: #32 Claude-Session: https://claude.ai/code/session_01RotroiBdbidiCRX3KqE3Dy
1 parent 418086b commit da485dd

2 files changed

Lines changed: 13 additions & 2 deletions

File tree

mix.exs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,18 @@ defmodule Castle.MixProject do
125125
# together, so each depends on the other's integration branch. This MUST be
126126
# flipped back to {:forecastle, "~> 1.0", runtime: false} before publishing:
127127
# mix hex.publish hard-fails on a git dependency.
128-
{:forecastle, github: "ausimian/forecastle", branch: "release/1.0.0", runtime: false},
128+
#
129+
# Pinned to `feature/upgrade-tooling` rather than `release/1.0.0` for the
130+
# duration of castle#32. The tooling work changes both halves at once - the
131+
# task rename and the appup coverage check are Forecastle's, the
132+
# `upgrade_from:` option is Castle's - so a branch here that read the
133+
# integration branch would be building against a Forecastle without them.
134+
# It goes back to `release/1.0.0` when that tree merges, and there is
135+
# precedent for forgetting: the fixture's own pin had to be moved off
136+
# castle#14's issue branch before that branch was deleted, which nothing
137+
# enforced either.
138+
{:forecastle,
139+
github: "ausimian/forecastle", branch: "feature/upgrade-tooling", runtime: false},
129140
{:credo, "~> 1.7", only: [:dev, :test], runtime: false},
130141
{:ex_doc, "~> 0.39", only: :dev, runtime: false},
131142
{:publisho, "~> 1.0", only: :dev, runtime: false}

mix.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"earmark_parser": {:hex, :earmark_parser, "1.4.46", "67607a0532e810c6f630a515c548d0b24949643f168cc556303bee4cf96105c7", [:mix], [], "hexpm", "9c44636e8a1c68c62f526b2dcd85d941dbbcee7ab82cf64ba06ce28bef8e89f5"},
55
"ex_doc": {:hex, :ex_doc, "0.40.3", "4a972ffe64bc07dc605af487e98fc19b72a4185f55ca031b94c0552d6071c1d9", [:mix], [{:earmark_parser, "~> 1.4.44", [hex: :earmark_parser, repo: "hexpm", optional: false]}, {:makeup_c, ">= 0.1.0", [hex: :makeup_c, repo: "hexpm", optional: true]}, {:makeup_elixir, "~> 0.14 or ~> 1.0", [hex: :makeup_elixir, repo: "hexpm", optional: false]}, {:makeup_erlang, "~> 0.1 or ~> 1.0", [hex: :makeup_erlang, repo: "hexpm", optional: false]}, {:makeup_html, ">= 0.1.0", [hex: :makeup_html, repo: "hexpm", optional: true]}], "hexpm", "2756e357742fecd9749b489b85d67c9ce99c465f2e75728d9e6dc8d704b973de"},
66
"file_system": {:hex, :file_system, "1.1.1", "31864f4685b0148f25bd3fbef2b1228457c0c89024ad67f7a81a3ffbc0bbad3a", [:mix], [], "hexpm", "7a15ff97dfe526aeefb090a7a9d3d03aa907e100e262a0f8f7746b78f8f87a5d"},
7-
"forecastle": {:git, "https://github.com/ausimian/forecastle.git", "27be4a7bd3bb5660f4444d9903ccfe23566b85e1", [branch: "release/1.0.0"]},
7+
"forecastle": {:git, "https://github.com/ausimian/forecastle.git", "e43f8808a4470a6952013cc8af56bec64877ef89", [branch: "feature/upgrade-tooling"]},
88
"jason": {:hex, :jason, "1.4.5", "2e3a008590b0b8d7388c20293e9dcc9cf3e5d642fd2a114e4cbbb52e595d940a", [:mix], [{:decimal, "~> 1.0 or ~> 2.0 or ~> 3.0", [hex: :decimal, repo: "hexpm", optional: true]}], "hexpm", "b0c823996102bcd0239b3c2444eb00409b72f6a140c1950bc8b457d836b30684"},
99
"makeup": {:hex, :makeup, "1.2.2", "882d46dc0905e9ff7abf2aab61a7e6b3dcc555533977d8a23b06019e6c89ac94", [:mix], [{:nimble_parsec, "~> 1.4", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "9a1a24e5b343b8ae16abea0822c10a6f75da27af7fa802ada5251f7579bfccfa"},
1010
"makeup_elixir": {:hex, :makeup_elixir, "1.0.1", "e928a4f984e795e41e3abd27bfc09f51db16ab8ba1aebdba2b3a575437efafc2", [:mix], [{:makeup, "~> 1.0", [hex: :makeup, repo: "hexpm", optional: false]}, {:nimble_parsec, "~> 1.2.3 or ~> 1.3", [hex: :nimble_parsec, repo: "hexpm", optional: false]}], "hexpm", "7284900d412a3e5cfd97fdaed4f5ed389b8f2b4cb49efc0eb3bd10e2febf9507"},

0 commit comments

Comments
 (0)