Commit 60fa2af
committed
Stub NAX JIT source providers when gated out
CI JIT=1 on macos-14 got past cmake configure but hit a linker
error:
symbol not found in flat namespace '__ZN3mlx4core5metal13quantized_naxEv'
jit_kernels.cpp references mlx::core::metal::{gemm_nax,
quantized_nax, fp_quantized_nax, steel_gemm_fused_nax, …} as strong
external symbols. Those symbols are normally supplied by the
auto-generated jit/<name>.cpp files that make_jit_source() creates;
when we gate those out for old SDKs, nothing provides them and the
NIF fails to link.
Extend the patch to emit an nax_stubs.cpp with empty-string returns
under the gated-out branch. The stubs are never exercised because
is_nax_available() returns false when MLX_METAL_NO_NAX is defined.1 parent bd3566d commit 60fa2af
1 file changed
Lines changed: 19 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
18 | 22 | | |
19 | 23 | | |
20 | 24 | | |
| |||
35 | 39 | | |
36 | 40 | | |
37 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
38 | 55 | | |
39 | 56 | | |
40 | 57 | | |
| |||
0 commit comments