Commit b571283
committed
docs(protocol): fix deprecation prose contradictions (codex review)
- sampling.rs module docs claimed ModelPreferences/ToolChoice/ToolChoiceMode/
ModelHint were "Types NOT deprecated" — contradicting the markers the
fidelity sweep added (and the schema's own @deprecated on all three named
interfaces). The prose now matches: those three are deprecated; the
unmarked leftovers are ToolChoiceMode (no schema symbol of its own — it
binds the inline mode union of the deprecated ToolChoice) and Role (used
outside sampling).
- roots.rs claimed notifications/roots/list_changed "was REMOVED entirely in
DRAFT-2026-v1" — true of this crate's pinned schema.ts (zero bindings) but
ambiguous as a live-spec claim, since the upstream lifecycle registry has
removed nothing yet. Reworded to the pinned-schema-scoped form per the
review doc's Authority note.
- logging.rs had the same "REMOVED entirely" phrasing for logging/setLevel
(caught by the slice-completion grep) — same pinned-schema-scoped rewording,
plus the per-request opt-in is correctly described as itself deprecated.1 parent b42c72b commit b571283
3 files changed
Lines changed: 18 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
15 | | - | |
16 | | - | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
17 | 19 | | |
18 | 20 | | |
19 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
16 | 19 | | |
17 | 20 | | |
18 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
21 | 24 | | |
22 | 25 | | |
23 | 26 | | |
| |||
0 commit comments