Incorrect incognito detection

[skywinder]

Bounty

Scope

• Incorrect incognito detection:
• After several minutes (3-7) burner wallet changes from normal mode to incognito mode. Actually, it is not incognito.

Steps to reproduce:

Open Firefox in normal mode

1. go to xdai.io
2. wait for 5-10 minutes.
3. Burner shows, that you are in incognito mode.

- OS: iOS 12 / iPhone XR
- Browser: Firefox 18.1

Deliverables

• We have to check code in this scope:

  burner-wallet/src/services/incogDetect.js

  Lines 2 to 20 in 77a0b0d

  	//snagged from https://stackoverflow.com/questions/52759238/private-incognito-mode-detection-for-ios-12-safari
  	function retry(isDone, next) {
  	var current_trial = 0, max_retry = 50, interval = 10, is_timeout = false;
  	var id = window.setInterval(
  	function() {
  	if (isDone()) {
  	window.clearInterval(id);
  	next(is_timeout);
  	}
  	if (current_trial++ > max_retry) {
  	window.clearInterval(id);
  	is_timeout = true;
  	next(is_timeout);
  	}
  	},
  	10
  	);
  	}

Roles

bounty gardener: @skywinder / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%

[yanyishuai]

Claiming #244 — focused fix per bounty scope.

[rovidev95]

False-positive incognito fix pushed to #317 — removed aggressive storage-quota heuristic; Firefox uses IndexedDB probe with 500ms timeout; inconclusive defaults to normal browsing. Fixes #244. @TimDaub