Scope
See function tokenSend: https://github.com/austintgriffith/burner-wallet/blob/master/src/App.js#L1604
It currently only returns the receipt in cb. There are, however, function calls in tokenSend that can throw errors. These should be thrown and handled in the functions calling tokenSend. Ideally, the "sending" view is then exited and an error is shown to the user via changeAlert.
A few examples where the error is not propagated to the user (might not be all):
Deliverables
Follow correct schema for cb: cb(error, receipt), as is common in JavaScript. Even better would be to get rid of cb altogether and use an async function and try-catch block.
Roles
bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%
Scope
See function
tokenSend: https://github.com/austintgriffith/burner-wallet/blob/master/src/App.js#L1604It currently only returns the receipt in
cb. There are, however, function calls in tokenSend that can throw errors. These should be thrown and handled in the functions calling tokenSend. Ideally, the "sending" view is then exited and an error is shown to the user viachangeAlert.A few examples where the error is not propagated to the user (might not be all):
Deliverables
Follow correct schema for
cb:cb(error, receipt), as is common in JavaScript. Even better would be to get rid ofcbaltogether and use anasyncfunction andtry-catchblock.Roles
bounty gardener: @TimDaub / 10%
bounty worker: name / 75%
bounty reviewer: name / 15%