Skip to content

Commit 353b971

Browse files
committed
remove the 'half-understood hack' added to fixup_args_size_notes years ago; it seems to cause ICEs.
(see #232, #244, #167)
1 parent 2a15e6f commit 353b971

File tree

1 file changed

+0
-15
lines changed

1 file changed

+0
-15
lines changed

gcc/gcc/expr.cc

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -4469,19 +4469,6 @@ fixup_args_size_notes (rtx_insn *prev, rtx_insn *last,
44694469
gcc_assert (!note || known_eq (args_size, get_args_size (note)));
44704470

44714471
poly_int64 this_delta = find_args_size_adjust (insn);
4472-
4473-
/* **** HALF-UNDERSTOOD HACK:
4474-
4475-
The original code here leaves out REG_ARGS_SIZE annotations for
4476-
instructions that don't adjust the stack under some circumstances.
4477-
4478-
In some situations, involving both m68k mac pascal functions
4479-
and exception handling, this leads to a failure in dwarf2cfi.c:combine_traces.
4480-
4481-
Disabling the if (this_delta == 0) fixes this, but causes the subsequent gcc_assert
4482-
to trip sometimes. Disabling both hasn't caused any observable problems... YET.
4483-
4484-
44854472
if (known_eq (this_delta, 0))
44864473
{
44874474
if (!CALL_P (insn)
@@ -4491,8 +4478,6 @@ fixup_args_size_notes (rtx_insn *prev, rtx_insn *last,
44914478
}
44924479

44934480
gcc_assert (!saw_unknown);
4494-
4495-
*/
44964481
if (known_eq (this_delta, HOST_WIDE_INT_MIN))
44974482
saw_unknown = true;
44984483

0 commit comments

Comments
 (0)