Skip to content

Commit 5db89fd

Browse files
WidcketSteve Hobbsevansims
authored
Merge fa into master (#167)
* Add migration guide [SDK-3393] (#127) Add migration guide * Remove license header from source files [SDK-3389] (#126) Remove license header * Update year in license file (#128) * Add `.swiftpm` directory to `.gitignore` (#131) Add `.swiftpm` to `.gitignore` * Add CONTRIBUTING.md (#130) * Drop old platform versions [SDK-3387] (#129) * Drop old platform versions * Remove preprocessor macros and compatibility code * Remove obsolete preprocessor macros * Use accesibility config when neither iOS nor macOS * Remove unnecessary preprocessor macros * Remove extra blank line at the end of the file * Restore Touch ID case * Remove leftover nested if * Update README [SDK-3416] (#135) * Remove deprecated method [SDK-3413] (#132) * Remove deprecated method * Add change to the migration guide * Remove usage of deprecated properties [SDK-3414] (#133) * Remove usage of deprecated APIs * Remove enum cases * Remove usage of enum cases * Update V1_MIGRATION_GUIDE.md Co-authored-by: Steve Hobbs <[email protected]> Co-authored-by: Steve Hobbs <[email protected]> * Add support policy [SDK-3420] (#138) * Fix typo in property name (#137) * Remove obsolete functionality [SDK-3419] (#136) * [SDK-3434] Update issues templates (#140) * [SDK-3434] Migrate GitHub issue templates * Update config.yml * Update config.yml * Add note about the Responsible Disclosure Program to bug reports template. * Remove "FAQ.md" reference, as there is no file * Update .github/ISSUE_TEMPLATE/Bug Report.yml * Update .github/ISSUE_TEMPLATE/Feature Request.yml * Update .github/ISSUE_TEMPLATE/Bug Report.yml * Update .github/ISSUE_TEMPLATE/Feature Request.yml * Update .github/ISSUE_TEMPLATE/config.yml * Update .github/ISSUE_TEMPLATE/config.yml * Update checkbox grouping * Update Pull Request template Co-authored-by: Rita Zerrizuela <[email protected]> * Migrate to Swift [SDK-3428] (#139) * Migrate to Swift * Add test case * Integrate SwiftLint * Add .swiftlint.yml * Fix tests * Add API docs * Update migration guide * Remove leftover comments * Update library description * Add snippets to the API docs * Drop Xcode 12.x and its older simulators * Add item to the migration guide * Drop support for old Swift versions [SDK-3444] (#141) * Add missing unit tests (#142) * Add missing tests * Remove extra whitespace * Add missing import for SPM * Apply recommended Xcode 14 settings (#143) * [SDK-3450] API Documentation Generation (#144) * Add generated API documentation to repo (#145) * Add support for iCloud synchronization (#146) * Add support for iCould synchronization * Update API docs * Add unit tests for queries (#147) Test queries * Improve API docs generation (#148) * Fix typos in tests (#149) * Make `context` parameter optional (#151) * Re-generate API docs (#152) * Complete README and Migration Guide [SDK-3397] (#150) * Add support for custom attributes (#153) * Replace OSX with macOS in schemes and targets (#154) Replace OSX with macOS * Release 1.0.0-fa.0 (#155) * Add fa to Podspec version (#156) * Fix 'access group' capitalization (#158) * Update API docs (#159) * Use Codecov orb (#161) * Create .semgrepignore * Add placeholders to issue forms (#162) * Update README for GA [SDK-3500] (#163) Update the README for GA * Merge `master` into `fa` (#164) Co-authored-by: Steve Hobbs <[email protected]> Co-authored-by: Evan Sims <[email protected]>
1 parent d0f93fa commit 5db89fd

File tree

195 files changed

+3271
-1715
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

195 files changed

+3271
-1715
lines changed

.circleci/config.yml

+11-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
version: 2.1
22

3+
orbs:
4+
codecov: codecov/codecov@3
5+
36
executors:
47
macos-executor:
58
parameters:
@@ -59,8 +62,10 @@ commands:
5962
name: Run iOS tests
6063
command: bundle exec fastlane ios ci
6164
- run:
62-
name: Upload coverage report
63-
command: bash <(curl -s https://codecov.io/bash) -J '<< parameters.scheme >>'
65+
name: Generate coverage report
66+
command: bundle exec slather coverage -x --output-directory output --arch x86_64 --scheme << parameters.scheme >>-iOS << parameters.scheme >>.xcodeproj
67+
- codecov/upload:
68+
file: output/cobertura.xml
6469
- run:
6570
name: Run pod lib lint
6671
command: bundle exec fastlane ios pod_lint
@@ -76,7 +81,7 @@ commands:
7681
- run:
7782
name: Run macOS tests
7883
command: |
79-
xcodebuild test -scheme << parameters.scheme >>-OSX -destination 'platform=macOS,arch=x86_64' | xcpretty
84+
xcodebuild test -scheme << parameters.scheme >>-macOS -destination 'platform=macOS,arch=x86_64' | xcpretty
8085
swift test
8186
test-tvos:
8287
parameters:
@@ -126,8 +131,8 @@ workflows:
126131
build:
127132
jobs:
128133
- build-and-test:
129-
scheme: "SimpleKeychain"
134+
scheme: SimpleKeychain
130135
matrix:
131136
parameters:
132-
platform: ["ios", "macos", "tvos"]
133-
xcode: ["13.0.0", "12.5.1"]
137+
platform: [ios, macos, tvos]
138+
xcode: ["13.0.0"]

.github/ISSUE_TEMPLATE/Bug Report.yml

+84
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
name: 🐞 Report a bug
2+
description: Have you found a bug or issue? Create a bug report for this library
3+
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
**Please do not report security vulnerabilities here**. The [Responsible Disclosure Program](https://auth0.com/responsible-disclosure-policy) details the procedure for disclosing security issues.
9+
10+
- type: checkboxes
11+
id: checklist
12+
attributes:
13+
label: Checklist
14+
options:
15+
- label: I have looked into the [README](https://github.com/auth0/SimpleKeychain#readme) and have not found a suitable solution or answer.
16+
required: true
17+
- label: I have searched the [issues](https://github.com/auth0/SimpleKeychain/issues) and have not found a suitable solution or answer.
18+
required: true
19+
- label: I have searched the [Auth0 Community](https://community.auth0.com/tags/c/sdks/5/ios) forums and have not found a suitable solution or answer.
20+
required: true
21+
- label: I agree to the terms within the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
22+
required: true
23+
24+
- type: textarea
25+
id: description
26+
attributes:
27+
label: Description
28+
description: Provide a clear and concise description of the issue, including what you expected to happen.
29+
validations:
30+
required: true
31+
32+
- type: textarea
33+
id: reproduction
34+
attributes:
35+
label: Reproduction
36+
description: Detail the steps taken to reproduce this error, and whether this issue can be reproduced consistently or if it is intermittent.
37+
placeholder: |
38+
1. Step 1...
39+
2. Step 2...
40+
3. ...
41+
validations:
42+
required: true
43+
44+
- type: input
45+
id: environment-version
46+
attributes:
47+
label: SimpleKeychain version
48+
validations:
49+
required: true
50+
51+
- type: dropdown
52+
id: environment-platform
53+
attributes:
54+
label: Platform
55+
multiple: true
56+
options:
57+
- iOS
58+
- macOS
59+
- tvOS
60+
- watchOS
61+
validations:
62+
required: true
63+
64+
- type: input
65+
id: environment-platform-version
66+
attributes:
67+
label: Platform version(s)
68+
validations:
69+
required: true
70+
71+
- type: input
72+
id: environment-xcode-version
73+
attributes:
74+
label: Xcode version
75+
validations:
76+
required: true
77+
78+
- type: input
79+
id: environment-package-manager
80+
attributes:
81+
label: Package manager
82+
placeholder: SPM, Cocoapods, Carthage, etc.
83+
validations:
84+
required: true
+51
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
name: 🧩 Feature request
2+
description: Suggest an idea or a feature for this library
3+
labels: ["feature request"]
4+
5+
body:
6+
- type: checkboxes
7+
id: checklist
8+
attributes:
9+
label: Checklist
10+
options:
11+
- label: I have looked into the [README](https://github.com/auth0/SimpleKeychain#readme) and have not found a suitable solution or answer.
12+
required: true
13+
- label: I have searched the [issues](https://github.com/auth0/SimpleKeychain/issues) and have not found a suitable solution or answer.
14+
required: true
15+
- label: I have searched the [Auth0 Community](https://community.auth0.com/tags/c/sdks/5/ios) forums and have not found a suitable solution or answer.
16+
required: true
17+
- label: I agree to the terms within the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
18+
required: true
19+
20+
- type: textarea
21+
id: description
22+
attributes:
23+
label: Describe the problem you'd like to have solved
24+
description: A clear and concise description of what the problem is.
25+
placeholder: I'm always frustrated when...
26+
validations:
27+
required: true
28+
29+
- type: textarea
30+
id: ideal-solution
31+
attributes:
32+
label: Describe the ideal solution
33+
description: A clear and concise description of what you want to happen.
34+
validations:
35+
required: true
36+
37+
- type: textarea
38+
id: alternatives-and-workarounds
39+
attributes:
40+
label: Alternatives and current workarounds
41+
description: A clear and concise description of any alternatives you've considered or any workarounds that are currently in place.
42+
validations:
43+
required: false
44+
45+
- type: textarea
46+
id: additional-context
47+
attributes:
48+
label: Additional context
49+
description: Add any other context or screenshots about the feature request here.
50+
validations:
51+
required: false

.github/ISSUE_TEMPLATE/config.yml

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
blank_issues_enabled: false
22
contact_links:
3-
- name: Auth0 Community
3+
- name: 🤔 Help & Questions
44
url: https://community.auth0.com/tags/c/sdks/5/ios
5-
about: Discuss this library in the Auth0 Community forums
5+
about: Ask general support or usage questions in the Auth0 Community forums
6+
- name: 🚀 Usage
7+
url: https://github.com/auth0/SimpleKeychain#usage
8+
about: Check the Usage section of the README to get up to speed with SimpleKeychain
9+
- name: 📖 API Documentation
10+
url: https://auth0.github.io/SimpleKeychain/
11+
about: Check the public API documentation for in-depth overview of all the available features

.github/ISSUE_TEMPLATE/feature_request.md

-27
This file was deleted.

.github/ISSUE_TEMPLATE/report-a-bug.md

-44
This file was deleted.

.github/PULL_REQUEST_TEMPLATE.md

+28-22
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,40 @@
1-
### Changes
1+
<!--
2+
❗ For general support or usage questions, use the Auth0 Community forums or raise a support ticket.
23
3-
Please describe both what is changing and why this is important. Include:
4+
By submitting a Pull Request to this repository, you agree to the terms within the Auth0 Code of Conduct: https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md.
5+
-->
46

5-
- Endpoints added, deleted, deprecated, or changed
6-
- Classes and methods added, deleted, deprecated, or changed
7-
- Screenshots of new or changed UI, if applicable
8-
- A summary of usage if this is a new feature or change to a public API (this should also be added to relevant documentation once released)
9-
- Any alternative designs or architectures considered
7+
- [ ] All new/changed/fixed functionality is covered by tests (or N/A)
8+
- [ ] I have added documentation for all new/changed functionality (or N/A)
109

11-
### References
10+
<!--
11+
❗ All the above items are required. Pull Requests with an incomplete or missing checklist will be unceremoniously closed.
12+
-->
1213

13-
Please include relevant links supporting this change such as a:
14+
### 📋 Changes
1415

15-
- support ticket
16-
- community post
17-
- StackOverflow post
18-
- support forum thread
16+
<!--
17+
Describe both what is changing and why this is important. Include:
1918
20-
### Testing
19+
- Types and methods added, deleted, deprecated, or changed
20+
- A summary of usage if this is a new feature or a change to a public API
21+
-->
2122

22-
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If helpful, please include manual testing steps as well.
23+
### 📎 References
2324

24-
[ ] This change adds unit test coverage (or why not)
25+
<!--
26+
Add relevant links supporting this change, such as:
2527
26-
[ ] This change has been tested on the latest version of the platform/language or why not
28+
- GitHub issue/PR number addressed or fixed
29+
- Auth0 Community post
30+
- StackOverflow answer
31+
- Related pull requests/issues from other repositories
2732
28-
### Checklist
33+
If there are no references, simply delete this section.
34+
-->
2935

30-
[ ] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md)
36+
### 🎯 Testing
3137

32-
[ ] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md)
33-
34-
[ ] All existing and new tests complete without errors
38+
<!--
39+
Describe how this can be tested by reviewers. Be specific about anything not tested and why. Include any manual steps for testing end-to-end, or for testing functionality not covered by unit tests.
40+
-->

.gitignore

+6-2
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,9 @@ fastlane/report.xml
3838
fastlane/screenshots/
3939

4040
#SwiftPM
41-
.build
42-
Package.resolved
41+
.swiftpm/
42+
.build/
43+
Package.resolved
44+
45+
# DocC
46+
docs.archive/

.semgrepignore

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
docs/
2+
SimpleKeychainTests/

.shiprc

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
2-
"files": {
3-
"SimpleKeychain/Info.plist": [],
4-
"SimpleKeychain.podspec": []
5-
},
6-
"postbump": "bundle update",
7-
"prefixVersion": false
2+
"files": {
3+
"SimpleKeychain/Info.plist": [],
4+
"SimpleKeychain.podspec": []
5+
},
6+
"postbump": "bundle update && bundle exec fastlane ios build_docs",
7+
"prefixVersion": false
88
}

.swiftlint.yml

+23
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
opt_in_rules: # some rules are only opt-in
2+
- empty_count
3+
# Find all the available rules by running:
4+
# swiftlint rules
5+
included: # paths to include during linting. `--path` is ignored if present.
6+
- SimpleKeychain
7+
excluded: # paths to ignore during linting. Takes precedence over `included`.
8+
- Carthage
9+
- Pods
10+
# configurable rules can be customized from this configuration file
11+
# rules that have both warning and error levels, can set just the warning level
12+
# implicitly
13+
line_length: 500
14+
# they can set both implicitly with an array
15+
type_body_length:
16+
- 300 # warning
17+
- 400 # error
18+
type_name:
19+
min_length: 3 # only warning
20+
identifier_name:
21+
min_length: # only min_length
22+
warning: 3 # only error
23+
reporter: "xcode" # reporter type (xcode, json, csv, checkstyle, junit)

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

-7
This file was deleted.

0 commit comments

Comments
 (0)