feat(analytics): unify command tracking events under a single method

Author: ramya18101

internal/analytics/analytics.go

@@ -51,13 +51,8 @@ func (t *Tracker) TrackFirstLogin(id string, loginType string) {
 	t.track(eventName, id, nil)
 }
 
-func (t *Tracker) TrackCommandSucceeded(commandPath string, id string) {
-	eventName := generateSucceededEventName(commandPath)
-	t.track(eventName, id, map[string]string{"success": "true", "error_class": "none"})
-}
-
-func (t *Tracker) TrackCommandFailed(commandPath string, id string, properties map[string]string) {
-	eventName := generateFailedEventName(commandPath)
+func (t *Tracker) TrackCommandRun(commandPath string, id string, properties map[string]string) {
+	eventName := generateRunEventName(commandPath)
 	t.track(eventName, id, properties)
 }
 
@@ -135,12 +130,8 @@ func newEvent(eventName string, id string, properties map[string]string) *event
 	}
 }
 
-func generateSucceededEventName(command string) string {
-	return generateEventName(command, "Succeeded")
-}
-
-func generateFailedEventName(command string) string {
-	return generateEventName(command, "Failed")
+func generateRunEventName(command string) string {
+	return generateEventName(command, "Run")
 }
 
 func generateEventName(command string, action string) string {

internal/analytics/analytics_test.go

@@ -34,30 +34,22 @@ func TestGenerateEventName(t *testing.T) {
 	})
 }
 
-func TestGenerateSucceededEventName(t *testing.T) {
+func TestGenerateRunEventName(t *testing.T) {
 	t.Run("generates from root command", func(t *testing.T) {
-		want := "CLI - Auth0 - Succeeded"
-		got := generateSucceededEventName("auth0")
+		want := "CLI - Auth0 - Run"
+		got := generateRunEventName("auth0")
 		assert.Equal(t, want, got)
 	})
 
 	t.Run("generates from top-level command", func(t *testing.T) {
-		want := "CLI - Auth0 - Apps - Succeeded"
-		got := generateSucceededEventName("auth0 apps")
-		assert.Equal(t, want, got)
-	})
-}
-
-func TestGenerateFailedEventName(t *testing.T) {
-	t.Run("generates from root command", func(t *testing.T) {
-		want := "CLI - Auth0 - Failed"
-		got := generateFailedEventName("auth0")
+		want := "CLI - Auth0 - Apps - Run"
+		got := generateRunEventName("auth0 apps")
 		assert.Equal(t, want, got)
 	})
 
 	t.Run("generates from subcommand", func(t *testing.T) {
-		want := "CLI - Apps - List - Failed"
-		got := generateFailedEventName("auth0 apps list")
+		want := "CLI - Apps - List - Run"
+		got := generateRunEventName("auth0 apps list")
 		assert.Equal(t, want, got)
 	})
 }

internal/cli/api.go

@@ -284,10 +284,8 @@ func (i *apiCmdInputs) parseRaw(args []string) {
 	i.RawURI = args[lenArgs-1]
 }
 
-// newAPIResponseError builds a go-auth0 v2 management error from a non-2xx raw
-// `auth0 api` response. Using the real management error type (rather than a
-// bespoke one) means classifyCommandFailure maps the status to an error_class
-// through the same path as the typed SDK commands.
+// newAPIResponseError turns non-2xx `auth0 api` responses into SDK management errors.
+// This keeps `error_class` handling consistent with typed SDK commands.
 func newAPIResponseError(statusCode int, header http.Header, body []byte) error {
 	message := strings.TrimSpace(string(body))
 	if message == "" {

internal/cli/root.go

@@ -239,11 +239,14 @@ func trackCommandOutcome(cli *cli, executionErr error) {
 	}
 
 	if executionErr != nil {
-		cli.tracker.TrackCommandFailed(cli.executedCommandPath, installID, classifyCommandFailure(executionErr))
+		cli.tracker.TrackCommandRun(cli.executedCommandPath, installID, classifyCommandFailure(executionErr))
 		return
 	}
 
-	cli.tracker.TrackCommandSucceeded(cli.executedCommandPath, installID)
+	cli.tracker.TrackCommandRun(cli.executedCommandPath, installID, map[string]string{
+		"success":     "true",
+		"error_class": "none",
+	})
 }
 
 func resolveInstallIDForTracking(cli *cli) string {