Skip to content

Conversation

@ankita10119
Copy link
Contributor

@ankita10119 ankita10119 commented Dec 11, 2025

Description

Add support for brute-force protection unblock screens to the Universal Login SDK.

Changes

  • Enabled brute-force protection screen type exports in auth0-acul-js interfaces that were previously commented out
  • Added three new React screen components in auth0-acul-react:
    • brute-force-protection-unblock - Main screen with unblockAccount() action
    • brute-force-protection-unblock-success - Success confirmation screen
    • brute-force-protection-unblock-failure - Failure handling screen
  • Exported new screens from auth0-acul-react package index
  • Each screen follows the established pattern with context hooks, error handling, and singleton instance registration

Testing

Tested with sample app.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@subhankarmaiti
Copy link
Contributor

@claude

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

Claude finished @subhankarmaiti's task —— View job


Overall Assessment

❌ This PR has test failures that must be fixed before merging. The test mocks are missing the useChangeLanguage hook export, which will cause test failures.

Summary

The implementation follows the established patterns correctly for adding new screen components. The three new brute-force protection screens (unblock, success, failure) are structured consistently with existing screens. However, there are critical issues in the test files that need to be addressed.

Issues Found

Critical (Must Fix):

  • All three test files are missing useChangeLanguage in their hook mocks, but the actual screen modules export this hook. This will cause test failures.

Minor (Should Review):

  • Inconsistent type export pattern in screen-properties.ts - lines 78-79 export additional screen-specific types that aren't exported for the main unblock screen on line 77.

What Looks Good

  • Screen component implementations follow the exact pattern used by other screens (e.g., reset-password-success.tsx)
  • Proper singleton registration with registerScreen
  • Correct use of errorManager.withError for the action function
  • Type exports are properly added to all necessary files
  • Package exports updated correctly in index.ts

Tasks

  • Read PR diff and understand changes
  • Read project documentation for context
  • Review new screen components
  • Review test files
  • Code quality review
  • Security review
  • Performance review
  • Provide inline feedback
  • Final assessment

@ankita10119 ankita10119 merged commit 9f757bc into master Dec 17, 2025
3 checks passed
@ankita10119 ankita10119 deleted the SDK-7276 branch December 17, 2025 19:38
ankita10119 added a commit that referenced this pull request Jan 12, 2026
**Added**
- docs: migration guide from JavaScript SDK to React SDK
[\#319](#319)
([amitsingh05667](https://github.com/amitsingh05667))
- Chore: support for brute-force-protection screens
[\#317](#317)
([ankita10119](https://github.com/ankita10119))
ankita10119 added a commit that referenced this pull request Jan 12, 2026
**Added**
- docs: migration guide from JavaScript SDK to React SDK
[\#319](#319)
([amitsingh05667](https://github.com/amitsingh05667))
- Chore: support for brute-force-protection screens
[\#317](#317)
([ankita10119](https://github.com/ankita10119))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants