-
Notifications
You must be signed in to change notification settings - Fork 11
Chore: support for brute-force-protection screens #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @subhankarmaiti's task —— View job Overall Assessment❌ This PR has test failures that must be fixed before merging. The test mocks are missing the SummaryThe implementation follows the established patterns correctly for adding new screen components. The three new brute-force protection screens (unblock, success, failure) are structured consistently with existing screens. However, there are critical issues in the test files that need to be addressed. Issues FoundCritical (Must Fix):
Minor (Should Review):
What Looks Good
Tasks
|
packages/auth0-acul-react/tests/screens/brute-force-protection-unblock.test.tsx
Show resolved
Hide resolved
packages/auth0-acul-react/tests/screens/brute-force-protection-unblock-success.test.tsx
Show resolved
Hide resolved
packages/auth0-acul-react/tests/screens/brute-force-protection-unblock-failure.test.tsx
Show resolved
Hide resolved
**Added** - docs: migration guide from JavaScript SDK to React SDK [\#319](#319) ([amitsingh05667](https://github.com/amitsingh05667)) - Chore: support for brute-force-protection screens [\#317](#317) ([ankita10119](https://github.com/ankita10119))
**Added** - docs: migration guide from JavaScript SDK to React SDK [\#319](#319) ([amitsingh05667](https://github.com/amitsingh05667)) - Chore: support for brute-force-protection screens [\#317](#317) ([ankita10119](https://github.com/ankita10119))
Description
Add support for brute-force protection unblock screens to the Universal Login SDK.
Changes
Testing
Tested with sample app.
Checklist