Replace duplicated user_id validate_challenge test with action test

Author: stevenclouston

authsignal/client_tests.py

@@ -151,22 +151,6 @@ def test_it_returns_success_if_user_id_is_correct(self):
         self.assertEqual(response["state"], "CHALLENGE_SUCCEEDED")
         self.assertTrue(response["is_valid"])
 
-    @responses.activate
-    def test_it_returns_isValid_false_user_id_is_incorrect(self):
-        responses.add(responses.POST, f"{base_challenge_url}/validate",
-            json={
-                'isValid': False, 
-                'error': 'User is invalid.',
-            },
-            status=200
-        )
-
-        response = self.authsignal_client.validate_challenge(user_id="malicious_user_id", token=self.jwt_token)
-
-        # self.assertEqual(response["error"], "CHALLENGE_SUCCEEDED")
-        self.assertFalse(response["is_valid"])
-
-
     @responses.activate
     def test_delete_user_authenticator(self):
         self.authsignal_client = client.Client(api_key='test_api_key')
@@ -195,6 +179,21 @@ def test_it_returns_success_false_if_user_id_is_incorrect(self):
         self.assertFalse(response['is_valid'])
         self.assertEqual(response.get("error"), "User is invalid.")
 
+    @responses.activate
+    def test_it_returns_isValid_false_if_action_is_incorrect(self):
+        responses.add(responses.POST, f"{base_challenge_url}/validate",
+            json={
+                'isValid': False, 
+                'error': 'Action is invalid.',
+            },
+            status=200
+        )
+
+        response = self.authsignal_client.validate_challenge(action="malicious_action_id", token=self.jwt_token)
+
+        # self.assertEqual(response["error"], "CHALLENGE_SUCCEEDED")
+        self.assertFalse(response["is_valid"])
+
     @responses.activate
     def test_it_returns_success_true_if_no_user_id_is_provided(self):
         responses.add(responses.POST, f"{base_challenge_url}/validate",