Remove insecure client tests from ci run

Author: tstirrat15

.github/workflows/test.yaml

@@ -13,10 +13,6 @@ jobs:
   pytest:
     name: "Unit and Integration Tests"
     runs-on: "ubuntu-latest"
-    services:
-      remote-spicedb:
-        image: "authzed/spicedb"
-        options: "--entrypoint 'spicedb serve-testing'"
     strategy:
       matrix:
         python-version:
@@ -43,11 +39,9 @@ jobs:
         with:
           version: "latest"
       - name: "Pytest"
-        # NOTE: the -m "" overrides the default marks, which
-        # selects the otherwise-unselected ci_only tests.
         run: |
           source ~/.cache/virtualenv/authzedpy/bin/activate
-          pytest -vv -m ""
+          pytest -vv
 
   protobuf:
     name: "Generate & Diff Protobuf"

pyproject.toml

@@ -47,12 +47,12 @@ ignore_missing_imports = true
 module = ["google.rpc.*", "grpcutil"]
 
 [tool.pytest.ini_options]
-addopts = "-x -m \"not ci_only\""
+addopts = "-x -m \"not remote_calls\""
 log_level = "debug"
 minversion = "6.0"
 asyncio_mode = "auto"
 markers = [
-"ci_only: marks tests that will only run in CI"
+"remote_calls: marks tests that make remote calls, not normally run"
 ]
 
 [tool.isort]

tests/insecure_client_test.py

@@ -10,30 +10,34 @@
 
 from .calls import write_test_schema
 
+## NOTE: these tests aren't usually run. They theoretically could and theoretically
+# should be run in CI, but getting an appropriate "remote" container is difficult with
+# github actions; this will happen at some point in the future.
+# To run them: `poetry run pytest -m ""`
+
 # NOTE: this is the name of the "remote" binding of the service container
 # in CI. These tests are only run in CI because otherwise setup is fiddly.
 # If you want to see these tests run locally, figure out your computer's
 # network-local IP address (typically 192.168.x.x) and make that the `remote_host`
 # string below, and then start up a testing container bound to that interface:
 # docker run --rm -p 192.168.x.x:50051:50051 authzed/spicedb serve-testing
-remote_host = "remote-spicedb"
-
+remote_host = "192.168.something.something"
 
-@pytest.mark.ci_only
+@pytest.mark.remote_calls
 async def test_normal_async_client_raises_error_on_insecure_remote_call(token):
     with pytest.raises(grpc.RpcError):
         client = AsyncClient(f"{remote_host}:50051", insecure_bearer_token_credentials(token))
         await write_test_schema(client)
 
 
-@pytest.mark.ci_only
+@pytest.mark.remote_calls
 async def test_normal_sync_client_raises_error_on_insecure_remote_call(token):
     with pytest.raises(grpc.RpcError):
         client = SyncClient(f"{remote_host}:50051", insecure_bearer_token_credentials(token))
         await write_test_schema(client)
 
 
-@pytest.mark.ci_only
+@pytest.mark.remote_calls
 async def test_insecure_client_makes_insecure_remote_call(token):
     insecure_client = InsecureClient(f"{remote_host}:50051", token)
     await write_test_schema(insecure_client)