|
| 1 | +package common |
| 2 | + |
| 3 | +import ( |
| 4 | + "fmt" |
| 5 | + "testing" |
| 6 | + |
| 7 | + "github.com/go-sql-driver/mysql" |
| 8 | + "github.com/stretchr/testify/require" |
| 9 | + |
| 10 | + dscommon "github.com/authzed/spicedb/internal/datastore/common" |
| 11 | +) |
| 12 | + |
| 13 | +func TestIsMissingTableError(t *testing.T) { |
| 14 | + t.Run("returns true for missing table error", func(t *testing.T) { |
| 15 | + mysqlErr := &mysql.MySQLError{ |
| 16 | + Number: mysqlMissingTableErrorNumber, |
| 17 | + Message: "Table 'spicedb.caveat' doesn't exist", |
| 18 | + } |
| 19 | + require.True(t, IsMissingTableError(mysqlErr)) |
| 20 | + }) |
| 21 | + |
| 22 | + t.Run("returns false for other mysql errors", func(t *testing.T) { |
| 23 | + mysqlErr := &mysql.MySQLError{ |
| 24 | + Number: 1062, // Duplicate entry error |
| 25 | + Message: "Duplicate entry '1' for key 'PRIMARY'", |
| 26 | + } |
| 27 | + require.False(t, IsMissingTableError(mysqlErr)) |
| 28 | + }) |
| 29 | + |
| 30 | + t.Run("returns false for non-mysql errors", func(t *testing.T) { |
| 31 | + err := fmt.Errorf("some other error") |
| 32 | + require.False(t, IsMissingTableError(err)) |
| 33 | + }) |
| 34 | + |
| 35 | + t.Run("returns false for nil error", func(t *testing.T) { |
| 36 | + require.False(t, IsMissingTableError(nil)) |
| 37 | + }) |
| 38 | + |
| 39 | + t.Run("returns true for wrapped missing table error", func(t *testing.T) { |
| 40 | + mysqlErr := &mysql.MySQLError{ |
| 41 | + Number: mysqlMissingTableErrorNumber, |
| 42 | + Message: "Table 'spicedb.caveat' doesn't exist", |
| 43 | + } |
| 44 | + wrappedErr := fmt.Errorf("query failed: %w", mysqlErr) |
| 45 | + require.True(t, IsMissingTableError(wrappedErr)) |
| 46 | + }) |
| 47 | +} |
| 48 | + |
| 49 | +func TestWrapMissingTableError(t *testing.T) { |
| 50 | + t.Run("wraps missing table error", func(t *testing.T) { |
| 51 | + mysqlErr := &mysql.MySQLError{ |
| 52 | + Number: mysqlMissingTableErrorNumber, |
| 53 | + Message: "Table 'spicedb.caveat' doesn't exist", |
| 54 | + } |
| 55 | + wrapped := WrapMissingTableError(mysqlErr) |
| 56 | + require.Error(t, wrapped) |
| 57 | + |
| 58 | + var schemaErr dscommon.SchemaNotInitializedError |
| 59 | + require.ErrorAs(t, wrapped, &schemaErr) |
| 60 | + require.Contains(t, wrapped.Error(), "spicedb datastore migrate") |
| 61 | + }) |
| 62 | + |
| 63 | + t.Run("returns nil for non-missing-table errors", func(t *testing.T) { |
| 64 | + mysqlErr := &mysql.MySQLError{ |
| 65 | + Number: 1062, // Duplicate entry error |
| 66 | + Message: "Duplicate entry '1' for key 'PRIMARY'", |
| 67 | + } |
| 68 | + require.NoError(t, WrapMissingTableError(mysqlErr)) |
| 69 | + }) |
| 70 | + |
| 71 | + t.Run("returns nil for non-mysql errors", func(t *testing.T) { |
| 72 | + err := fmt.Errorf("some other error") |
| 73 | + require.NoError(t, WrapMissingTableError(err)) |
| 74 | + }) |
| 75 | + |
| 76 | + t.Run("returns nil for nil error", func(t *testing.T) { |
| 77 | + require.NoError(t, WrapMissingTableError(nil)) |
| 78 | + }) |
| 79 | + |
| 80 | + t.Run("preserves original error in chain", func(t *testing.T) { |
| 81 | + mysqlErr := &mysql.MySQLError{ |
| 82 | + Number: mysqlMissingTableErrorNumber, |
| 83 | + Message: "Table 'spicedb.caveat' doesn't exist", |
| 84 | + } |
| 85 | + wrapped := WrapMissingTableError(mysqlErr) |
| 86 | + require.Error(t, wrapped) |
| 87 | + |
| 88 | + // The original mysql error should be accessible via unwrapping |
| 89 | + var foundMySQLErr *mysql.MySQLError |
| 90 | + require.ErrorAs(t, wrapped, &foundMySQLErr) |
| 91 | + require.Equal(t, uint16(mysqlMissingTableErrorNumber), foundMySQLErr.Number) |
| 92 | + }) |
| 93 | + |
| 94 | + t.Run("does not double-wrap already wrapped errors", func(t *testing.T) { |
| 95 | + mysqlErr := &mysql.MySQLError{ |
| 96 | + Number: mysqlMissingTableErrorNumber, |
| 97 | + Message: "Table 'spicedb.caveat' doesn't exist", |
| 98 | + } |
| 99 | + // First wrap |
| 100 | + wrapped := WrapMissingTableError(mysqlErr) |
| 101 | + require.Error(t, wrapped) |
| 102 | + |
| 103 | + // Second wrap should return the already-wrapped error (preserving it through call chain) |
| 104 | + doubleWrapped := WrapMissingTableError(wrapped) |
| 105 | + require.Error(t, doubleWrapped) |
| 106 | + require.Equal(t, wrapped, doubleWrapped) |
| 107 | + |
| 108 | + // Should still be detectable as SchemaNotInitializedError |
| 109 | + var schemaErr dscommon.SchemaNotInitializedError |
| 110 | + require.ErrorAs(t, doubleWrapped, &schemaErr) |
| 111 | + }) |
| 112 | +} |
0 commit comments