Merge pull request #2350 from josephschorr/test-http-readonly-flake

Disable test of readonly serve-test, as it is making the test server …

Author: josephschorr

cmd/spicedb/servetesting_integration_test.go

@@ -8,10 +8,8 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"io/ioutil"
 	"log"
 	"net/http"
-	"strings"
 	"testing"
 	"time"
 
@@ -43,7 +41,7 @@ func TestTestServer(t *testing.T) {
 				"--http-addr", ":8443",
 				"--readonly-http-addr", ":8444",
 				"--http-enabled",
-				"--readonly-http-enabled",
+				//"--readonly-http-enabled",
 			},
 			ExposedPorts: []string{"50051/tcp", "50052/tcp", "8443/tcp", "8444/tcp"},
 		},
@@ -158,17 +156,20 @@ func TestTestServer(t *testing.T) {
 	require.Contains(string(body), "schemaText")
 	require.Contains(string(body), "definition resource")
 
-	// Attempt to write to the read only HTTP and ensure it fails.
-	writeUrl := fmt.Sprintf("http://localhost:%s/v1/schema/write", tester.readonlyHttpPort)
-	wresp, err := http.Post(writeUrl, "application/json", strings.NewReader(`{
-		"schemaText": "definition user {}\ndefinition resource {\nrelation reader: user\nrelation writer: user\nrelation foobar: user\n}"
-	}`))
-	require.NoError(err)
-	require.Equal(503, wresp.StatusCode)
-
-	body, err = ioutil.ReadAll(wresp.Body)
-	require.NoError(err)
-	require.Contains(string(body), "SERVICE_READ_ONLY")
+	/*
+		 * TODO(jschorr): Re-enable once we figure out why this makes the test flaky
+		// Attempt to write to the read only HTTP and ensure it fails.
+		writeUrl := fmt.Sprintf("http://localhost:%s/v1/schema/write", tester.readonlyHttpPort)
+		wresp, err := http.Post(writeUrl, "application/json", strings.NewReader(`{
+			"schemaText": "definition user {}\ndefinition resource {\nrelation reader: user\nrelation writer: user\nrelation foobar: user\n}"
+		}`))
+		require.NoError(err)
+		require.Equal(503, wresp.StatusCode)
+
+		body, err = ioutil.ReadAll(wresp.Body)
+		require.NoError(err)
+		require.Contains(string(body), "SERVICE_READ_ONLY")
+	*/
 }
 
 type spicedbHandle struct {