finish tests

Author: barakmich

pkg/schema/type_check.go

@@ -43,7 +43,7 @@ func (ts *TypeSystem) getTypesForInfo(ctx context.Context, defName string, rel *
 		if dr.GetRelation() == ellipsesRelation {
 			out.Add(dr.GetNamespace())
 		} else if dr.GetRelation() != "" {
-			rest, err := ts.getTypesForRelationInternal(ctx, defName, dr.GetRelation(), seen)
+			rest, err := ts.getTypesForRelationInternal(ctx, dr.GetNamespace(), dr.GetRelation(), seen)
 			if err != nil {
 				return nil, err
 			}

pkg/schema/type_check_test.go

@@ -100,6 +100,64 @@ func TestTypechecking(t *testing.T) {
 				"resource#viewer":     {"user", "organization"},
 			},
 		},
+		{
+			name: "subrel",
+			schemaText: `
+			definition user {}
+
+			definition organization {
+				relation member: user
+			}
+
+			definition resource {
+				relation viewer: organization#member
+			}
+		`,
+			expected: map[string][]string{
+				"organization#member": {"user"},
+				"resource#viewer":     {"user"},
+			},
+		},
+		{
+			name: "wildcard",
+			schemaText: `
+			definition user {}
+
+			definition organization {
+				relation member: user:*
+			}
+
+			definition resource {
+				relation viewer: organization#member
+			}
+		`,
+			expected: map[string][]string{
+				"organization#member": {"user"},
+				"resource#viewer":     {"user"},
+			},
+		},
+		{
+			name: "banned",
+			schemaText: `
+			definition user {}
+
+			definition organization {
+				relation member: user
+			}
+
+			definition resource {
+				relation viewer: organization#member
+				relation banned: user
+				permission view = viewer - banned
+			}
+		`,
+			expected: map[string][]string{
+				"organization#member": {"user"},
+				"resource#viewer":     {"user"},
+				"resource#banned":     {"user"},
+				"resource#view":       {"user"},
+			},
+		},
 	}
 	for _, tc := range tcs {
 		t.Run(tc.name, func(t *testing.T) {