chore: add perfsprint linter

Author: miparnisari

.golangci.yaml

@@ -28,6 +28,7 @@ linters:
     - "importas"
     - "ineffassign"
     - "makezero"
+    - "perfsprint"
     - "prealloc"
     - "predeclared"
     - "promlinter"
@@ -90,6 +91,9 @@ linters:
       - linters:
           - "revive"
         text: 'receiver-naming: receiver name \S+ should be consistent with previous receiver name \S+ for invalid-type'
+      - linters:
+          - "perfsprint"
+        path: '(.+)_test\.go'
     paths:
       - "third_party$"
       - "builtin$"

internal/caveats/run.go

@@ -3,7 +3,6 @@ package caveats
 import (
 	"context"
 	"errors"
-	"fmt"
 	"maps"
 
 	"go.opentelemetry.io/otel"
@@ -95,7 +94,7 @@ func (cr *CaveatRunner) PopulateCaveatDefinitionsForExpr(ctx context.Context, ex
 	span.SetAttributes(attribute.StringSlice(otelconv.AttrCaveatsNames, caveatNames.AsSlice()))
 
 	if caveatNames.IsEmpty() {
-		return fmt.Errorf("received empty caveat expression")
+		return errors.New("received empty caveat expression")
 	}
 
 	// Remove any caveats already loaded.
@@ -416,7 +415,7 @@ func (sr syntheticResult) MissingVarNames() ([]string, error) {
 		return missingVarNames.AsSlice(), nil
 	}
 
-	return nil, fmt.Errorf("not a partial value")
+	return nil, errors.New("not a partial value")
 }
 
 func isFalseResult(result ExpressionResult) bool {

internal/datasets/subjectsetbyresourceid.go

@@ -1,6 +1,7 @@
 package datasets
 
 import (
+	"errors"
 	"fmt"
 
 	v1 "github.com/authzed/spicedb/pkg/proto/dispatch/v1"
@@ -22,7 +23,7 @@ type SubjectSetByResourceID struct {
 
 func (ssr SubjectSetByResourceID) add(resourceID string, subject *v1.FoundSubject) error {
 	if subject == nil {
-		return fmt.Errorf("cannot add a nil subject to SubjectSetByResourceID")
+		return errors.New("cannot add a nil subject to SubjectSetByResourceID")
 	}
 
 	_, ok := ssr.subjectSetByResourceID[resourceID]

internal/datastore/common/relationships.go

@@ -3,6 +3,7 @@ package common
 import (
 	"context"
 	"database/sql"
+	"errors"
 	"fmt"
 	"time"
 
@@ -79,7 +80,7 @@ func runExplainIfNecessary[R Rows](ctx context.Context, builder RelationshipsQue
 			explainString += explain + "\n"
 		}
 		if explainString == "" {
-			return fmt.Errorf("received empty explain")
+			return errors.New("received empty explain")
 		}
 
 		return builder.SQLExplainCallbackForTest(ctx, sqlString, args, builder.queryShape, explainString, expectedIndexes)

internal/datastore/crdb/crdb.go

@@ -145,7 +145,7 @@ func newCRDBDatastore(ctx context.Context, url string, options ...Option) (datas
 	switch config.overlapStrategy {
 	case overlapStrategyStatic:
 		if len(config.overlapKey) == 0 {
-			return nil, fmt.Errorf("static tx overlap strategy specified without an overlap key")
+			return nil, errors.New("static tx overlap strategy specified without an overlap key")
 		}
 		keyer = appendStaticKey(config.overlapKey)
 	case overlapStrategyPrefix:
@@ -577,7 +577,7 @@ func (cds *crdbDatastore) features(ctx context.Context) (*datastore.Features, er
 			}
 
 			features.Watch.Status = datastore.FeatureUnsupported
-			features.Watch.Reason = fmt.Sprintf("Range feeds must be enabled in CockroachDB and the user must have permission to create them in order to enable the Watch API: %s", err.Error())
+			features.Watch.Reason = "Range feeds must be enabled in CockroachDB and the user must have permission to create them in order to enable the Watch API: " + err.Error()
 			return nil
 		}, fmt.Sprintf(cds.beginChangefeedQuery, cds.schema.RelationshipTableName, head, "-1s"))
 	} else {
@@ -626,7 +626,7 @@ func readClusterTTLNanos(ctx context.Context, conn pgxcommon.DBFuncQuerier) (int
 
 	groups := gcTTLRegex.FindStringSubmatch(configSQL)
 	if groups == nil || len(groups) != 2 {
-		return 0, fmt.Errorf("CRDB zone config unexpected format")
+		return 0, errors.New("CRDB zone config unexpected format")
 	}
 
 	gcSeconds, err := strconv.ParseInt(groups[1], 10, 64)

internal/datastore/crdb/watch.go

@@ -93,7 +93,7 @@ func (cds *crdbDatastore) Watch(ctx context.Context, afterRevision datastore.Rev
 
 		if features.Watch.Status != datastore.FeatureSupported {
 			close(updates)
-			errs <- datastore.NewWatchDisabledErr(fmt.Sprintf("%s. See https://spicedb.dev/d/enable-watch-api-crdb", features.Watch.Reason))
+			errs <- datastore.NewWatchDisabledErr(features.Watch.Reason + ". See https://spicedb.dev/d/enable-watch-api-crdb")
 			return updates, errs
 		}
 	}
@@ -147,12 +147,12 @@ func (cds *crdbDatastore) watch(
 	}
 
 	if len(tableNames) == 0 {
-		errs <- fmt.Errorf("at least relationships or schema must be specified")
+		errs <- errors.New("at least relationships or schema must be specified")
 		return
 	}
 
 	if opts.CheckpointInterval < 0 {
-		errs <- fmt.Errorf("invalid checkpoint interval given")
+		errs <- errors.New("invalid checkpoint interval given")
 		return
 	}
 

internal/datastore/dsfortesting/dsfortesting.go

@@ -2,6 +2,7 @@ package dsfortesting
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"time"
 
@@ -84,7 +85,7 @@ func (vr validatingReader) QueryRelationships(
 
 	_, _ = executor.ExecuteQuery(ctx, qBuilder, options...)
 	if builder == nil {
-		return nil, fmt.Errorf("no builder returned")
+		return nil, errors.New("no builder returned")
 	}
 
 	checkStaticField := func(returnedValue string, fieldName string) error {

internal/datastore/memdb/memdb.go

@@ -120,7 +120,7 @@ func (mdb *memdbDatastore) SnapshotReader(dr datastore.Revision) datastore.Reade
 	}
 
 	if len(mdb.revisions) == 0 {
-		return &memdbReader{nil, nil, fmt.Errorf("memdb datastore is not ready"), time.Now()}
+		return &memdbReader{nil, nil, errors.New("memdb datastore is not ready"), time.Now()}
 	}
 
 	if err := mdb.checkRevisionLocalCallerMustLock(dr); err != nil {
@@ -138,7 +138,7 @@ func (mdb *memdbDatastore) SnapshotReader(dr datastore.Revision) datastore.Reade
 
 	rev := mdb.revisions[revIndex]
 	if rev.db == nil {
-		return &memdbReader{nil, nil, fmt.Errorf("memdb datastore is already closed"), time.Now()}
+		return &memdbReader{nil, nil, errors.New("memdb datastore is already closed"), time.Now()}
 	}
 
 	roTxn := rev.db.Txn(false)

internal/datastore/memdb/readwrite.go

@@ -3,6 +3,7 @@ package memdb
 import (
 	"cmp"
 	"context"
+	"errors"
 	"fmt"
 	"strings"
 
@@ -313,7 +314,7 @@ func (rwt *memdbReadWriteTx) DeleteNamespaces(_ context.Context, nsNames ...stri
 		}
 
 		if foundRaw == nil {
-			return fmt.Errorf("namespace not found")
+			return errors.New("namespace not found")
 		}
 
 		if err := tx.Delete(tableNamespace, foundRaw); err != nil {

internal/datastore/postgres/postgres.go

@@ -80,7 +80,7 @@ var (
 	getRevisionForGC = psql.
 				Select(schema.ColXID, schema.ColSnapshot).
 				From(schema.TableTransaction).
-				OrderByClause(fmt.Sprintf("%s DESC", schema.ColXID)).
+				OrderByClause(schema.ColXID + " DESC").
 				Limit(1)
 
 	createTxn = psql.Insert(schema.TableTransaction).Columns(schema.ColMetadata)
@@ -243,7 +243,7 @@ func newPostgresDatastore(
 		replicaIndexStr := strconv.Itoa(replicaIndex)
 		dbname := "spicedb"
 		if replicaIndex != primaryInstanceID {
-			dbname = fmt.Sprintf("spicedb_replica_%s", replicaIndexStr)
+			dbname = "spicedb_replica_" + replicaIndexStr
 		}
 
 		if err := prometheus.Register(pgxpoolprometheus.NewCollector(readPool, map[string]string{
@@ -533,7 +533,7 @@ func (pgd *pgDatastore) Repair(ctx context.Context, operationName string, output
 		return pgd.repairTransactionIDs(ctx, outputProgress)
 
 	default:
-		return fmt.Errorf("unknown operation")
+		return errors.New("unknown operation")
 	}
 }