Use golangci-lint v2 (#484)

Author: tstirrat15

.github/workflows/lint.yaml

@@ -20,7 +20,7 @@ jobs:
       - uses: "authzed/actions/gofumpt@main"
       - uses: "authzed/actions/go-mod-tidy@main"
       - uses: "authzed/actions/go-generate@main"
-      - uses: "authzed/actions/golangci-lint@main"
+      - uses: "authzed/actions/golangci-lint@golangci-lint-v2"
 
   extra-lint:
     name: "Lint YAML & Markdown"

.golangci.yaml

@@ -1,37 +1,46 @@
 ---
-run:
-  timeout: "5m"
-output:
-  sort-results: true
-linters-settings:
-  goimports:
-    local-prefixes: "github.com/authzed/zed"
+version: "2"
 linters:
   enable:
     - "bidichk"
     - "bodyclose"
-    - "errcheck"
     - "errname"
     - "errorlint"
-    - "gofumpt"
-    - "goimports"
     - "goprintffuncname"
     - "gosec"
-    - "gosimple"
-    - "govet"
     - "importas"
-    - "ineffassign"
     - "makezero"
     - "prealloc"
     - "predeclared"
     - "promlinter"
     - "revive"
     - "rowserrcheck"
     - "staticcheck"
-    - "stylecheck"
-    - "tenv"
-    - "typecheck"
     - "unconvert"
-    - "unused"
     - "wastedassign"
     - "whitespace"
+  exclusions:
+    generated: "lax"
+    presets:
+      - "comments"
+      - "common-false-positives"
+      - "legacy"
+      - "std-error-handling"
+    paths:
+      - "third_party$"
+      - "builtin$"
+      - "examples$"
+formatters:
+  enable:
+    - "gofumpt"
+    - "goimports"
+  settings:
+    goimports:
+      local-prefixes:
+        - "github.com/authzed/zed"
+  exclusions:
+    generated: "lax"
+    paths:
+      - "third_party$"
+      - "builtin$"
+      - "examples$"

internal/printers/debug.go

@@ -33,13 +33,15 @@ func displayCheckTrace(checkTrace *v1.CheckDebugTrace, tp *TreePrinter, hasError
 	resourceColor := white
 	permissionColor := color.FgWhite.Render
 
-	if checkTrace.PermissionType == v1.CheckDebugTrace_PERMISSION_TYPE_PERMISSION {
+	switch checkTrace.PermissionType {
+	case v1.CheckDebugTrace_PERMISSION_TYPE_PERMISSION:
 		permissionColor = lightgreen
-	} else if checkTrace.PermissionType == v1.CheckDebugTrace_PERMISSION_TYPE_RELATION {
+	case v1.CheckDebugTrace_PERMISSION_TYPE_RELATION:
 		permissionColor = orange
 	}
 
-	if checkTrace.Result == v1.CheckDebugTrace_PERMISSIONSHIP_CONDITIONAL_PERMISSION {
+	switch checkTrace.Result {
+	case v1.CheckDebugTrace_PERMISSIONSHIP_CONDITIONAL_PERMISSION:
 		switch checkTrace.CaveatEvaluationInfo.Result {
 		case v1.CaveatEvalInfo_RESULT_FALSE:
 			hasPermission = red("⨉")
@@ -51,11 +53,11 @@ func displayCheckTrace(checkTrace *v1.CheckDebugTrace, tp *TreePrinter, hasError
 			resourceColor = faint
 			permissionColor = faint
 		}
-	} else if checkTrace.Result == v1.CheckDebugTrace_PERMISSIONSHIP_NO_PERMISSION {
+	case v1.CheckDebugTrace_PERMISSIONSHIP_NO_PERMISSION:
 		hasPermission = red("⨉")
 		resourceColor = faint
 		permissionColor = faint
-	} else if checkTrace.Result == v1.CheckDebugTrace_PERMISSIONSHIP_UNSPECIFIED {
+	case v1.CheckDebugTrace_PERMISSIONSHIP_UNSPECIFIED:
 		hasPermission = yellow("∵")
 	}