Skip to content

Fix S1066: merge collapsible if statements. #142

Fix S1066: merge collapsible if statements.

Fix S1066: merge collapsible if statements. #142

Triggered via push May 28, 2026 21:46
Status Failure
Total duration 1m 42s
Artifacts

ci.yml

on: push
publish  /  publish
publish / publish
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 11 warnings
build / build: src/Autofac/Core/Registration/ComponentRegistrationLifetimeDecorator.cs#L13
Fix this implementation of 'IDisposable' to conform to the dispose pattern.
build / build: src/Autofac/Core/Activators/Reflection/InjectableProperty.cs#L15
Remove the field '_setter' and declare it as a local variable in the relevant methods.
build / build: src/Autofac/Core/Parameter.cs#L15
Convert this 'abstract' class to an interface.
build / build: src/Autofac/Util/FallbackDictionary.cs#L91
Refactor 'Keys' into a method, properties should not copy collections.
build / build: src/Autofac/Util/Disposable.cs#L9
Fix this implementation of 'IDisposable' to conform to the dispose pattern.
build / build: src/Autofac/Diagnostics/DefaultDiagnosticTracer.cs#L237
Private classes which are not derived in the current assembly should be marked as 'sealed'.
build / build: src/Autofac/Core/Registration/ExternalComponentRegistration.cs#L30
Private classes which are not derived in the current assembly should be marked as 'sealed'.
build / build: src/Autofac/Builder/DynamicRegistrationStyle.cs#L9
Remove this empty class, write its code or make it an "interface".
dotnet-format / dotnet-format
Process completed with exit code 2.
pre-commit / pre-commit
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
dotnet-format / dotnet-format: src/Autofac/Core/Activators/Reflection/ReflectionActivator.cs#L433
Refactor this method to reduce its Cognitive Complexity from 37 to the 15 allowed.
dotnet-format / dotnet-format: src/Autofac/Core/Activators/Reflection/ReflectionActivator.cs#L211
Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed.
dotnet-format / dotnet-format: src/Autofac/Core/Activators/Reflection/ReflectionActivator.cs#L85
Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.
dotnet-format / dotnet-format: src/Autofac/RegistrationExtensions.Decorators.cs#L19
An opening brace should not be followed by a blank line
dotnet-format / dotnet-format: src/Autofac/Features/Collections/CollectionRegistrationSource.cs#L194
Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.
dotnet-format / dotnet-format: src/Autofac/Features/Collections/CollectionRegistrationSource.cs#L61
Refactor this method to reduce its Cognitive Complexity from 23 to the 15 allowed.
dotnet-format / dotnet-format: src/Autofac/Features/AttributeFilters/KeyFilterAttribute.cs#L76
Specify AttributeUsage on 'KeyFilterAttribute' to improve readability, even though it inherits it from its base type.
dotnet-format / dotnet-format: src/Autofac/Diagnostics/DefaultDiagnosticTracer.cs#L237
Private classes which are not derived in the current assembly should be marked as 'sealed'.
dotnet-format / dotnet-format: src/Autofac/Core/Registration/ExternalComponentRegistration.cs#L30
Private classes which are not derived in the current assembly should be marked as 'sealed'.