Skip to content

Improve saving and noting changes workflow #60

Open
@gterzian

Description

See discussion at #58 (comment)

The idea is to move the concept of last_heads: Vec<ChangeHash>, currently one per document, to a "per pending save per document" one, by moving it to DocState::Sync and DocState::PendingRemoval.

Processing would have happen at two places:

  1. Inside note_changes, which would use the data found on the doc state instead of self.last_heads(this would remove the read lock by the way).

  2. Inside save_document, which would use the last (fut, last_heads) pair to compute the next one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions