Skip to content

Rename metrics to be in line with OTel + Prometheus conventions #21

Open
@emschwartz

Description

@emschwartz

As discussed here, OpenTelemetry is changing its semantic conventions to remove the .count suffix. Also, as discussed here, the histogram should include the units in the name for Prometheus.

We should update all of the libraries such that:

  • The counter is renamed from function.calls.count to function.calls
  • The histogram should include the unit as seconds (in the OpenTelemetry metadata or in the name for Prometheus)
  • When the metrics are exported to Prometheus, we should ensure that the counter is renamed to function_calls_total and the histogram is renamed to function_calls_duration_seconds
  • All queries should be updated to use the function_calls_total and function_calls_duration_seconds name. We can give people time to update things by making the alerting rules and dashboards support the new and old names using regular expressions.

TODO:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    In Progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions