Skip to content

fANOVA crashes on depths larger than two #197

@Michael190502

Description

@Michael190502

Hi,

I think I found a potential bug in the following line https://github.com/automl/DeepCAVE/blob/58d6801508468841eda038803b12fa2bbf7a0cb8/deepcave/evaluators/epm/fanova_forest.py#L214C26-L214C43 . Shouldnt is be self.compute_marginals(sub_hp_ids, k)? If I am not mistaken the current implementation blocks the computation of marginals of sets larger than 2 as the compute marginal function returns empty lists if depth + 1 is greater than len(hp_ids) and the default depth is 1.

Concretely I get an IndexError for vu_total for subsets larger than 2 in the current implementation.

If I missed something please let me know. Thank you.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions