Test Plan
Currently we're doing manual testing, but we should automate it (and add it to CI).
Here's how this is implemented in PR #17:
- instead of making Slack calls in each alert checker, send the found alerts through a channel to a task that sends alerts
- in tests, check known alerting blocks from the node, then check the expected alerts were sent on the channel
Later, this will allow us to combine multiple alerts from the same block into the same message, which helps with usability (and Slack rate limits).
As part of these tests, we might need to make some alert thresholds configurable.
Missing Tests
Test Plan
Currently we're doing manual testing, but we should automate it (and add it to CI).
Here's how this is implemented in PR #17:
Later, this will allow us to combine multiple alerts from the same block into the same message, which helps with usability (and Slack rate limits).
As part of these tests, we might need to make some alert thresholds configurable.
Missing Tests