Merge pull request #3435 from autonomys/pallet-messenger-general-extrinsic

Migrate pallet-messenger to General Unsigned extrinsics

Author: vedhavyas

Cargo.lock

@@ -36,6 +36,7 @@ hex-literal.workspace = true
 log.workspace = true
 mimalloc.workspace = true
 pallet-domains.workspace = true
+pallet-messenger.workspace = true
 pallet-transaction-payment.workspace = true
 parity-scale-codec.workspace = true
 pallet-subspace.workspace = true

crates/subspace-malicious-operator/Cargo.toml

@@ -418,6 +418,7 @@ fn get_singed_extra(best_number: u64, immortal: bool, nonce: Nonce) -> SignedExt
         DisablePallets,
         pallet_subspace::extensions::SubspaceExtension::<Runtime>::new(),
         pallet_domains::extensions::DomainsExtension::<Runtime>::new(),
+        pallet_messenger::extensions::MessengerExtension::<Runtime>::new(),
     )
 }
 
@@ -444,6 +445,7 @@ pub fn construct_signed_extrinsic(
             (),
             (),
             (),
+            (),
         ),
     );
 

crates/subspace-malicious-operator/src/malicious_bundle_producer.rs

@@ -713,6 +713,7 @@ impl pallet_messenger::Config for Runtime {
     type DomainRegistration = DomainRegistration;
     type ChannelFeeModel = ChannelFeeModel;
     type MaxOutgoingMessages = MaxOutgoingMessages;
+    type MessengerOrigin = pallet_messenger::EnsureMessengerOrigin;
 }
 
 impl<C> frame_system::offchain::CreateTransactionBase<C> for Runtime
@@ -1038,6 +1039,7 @@ pub type SignedExtra = (
     DisablePallets,
     pallet_subspace::extensions::SubspaceExtension<Runtime>,
     pallet_domains::extensions::DomainsExtension<Runtime>,
+    pallet_messenger::extensions::MessengerExtension<Runtime>,
 );
 /// Unchecked extrinsic type as expected by this runtime.
 pub type UncheckedExtrinsic =
@@ -1076,6 +1078,15 @@ impl pallet_domains::extensions::MaybeDomainsCall<Runtime> for RuntimeCall {
     }
 }
 
+impl pallet_messenger::extensions::MaybeMessengerCall<Runtime> for RuntimeCall {
+    fn maybe_messenger_call(&self) -> Option<&pallet_messenger::Call<Runtime>> {
+        match self {
+            RuntimeCall::Messenger(call) => Some(call),
+            _ => None,
+        }
+    }
+}
+
 fn extract_segment_headers(ext: &UncheckedExtrinsic) -> Option<Vec<SegmentHeader>> {
     match &ext.function {
         RuntimeCall::Subspace(pallet_subspace::Call::store_segment_headers { segment_headers }) => {
@@ -1130,6 +1141,7 @@ fn create_unsigned_general_extrinsic(call: RuntimeCall) -> UncheckedExtrinsic {
         DisablePallets,
         pallet_subspace::extensions::SubspaceExtension::<Runtime>::new(),
         pallet_domains::extensions::DomainsExtension::<Runtime>::new(),
+        pallet_messenger::extensions::MessengerExtension::<Runtime>::new(),
     );
 
     UncheckedExtrinsic::new_transaction(call, extra)

crates/subspace-runtime/src/lib.rs

@@ -27,6 +27,7 @@ sp-mmr-primitives.workspace = true
 sp-runtime.workspace = true
 sp-trie.workspace = true
 sp-subspace-mmr.workspace = true
+subspace-runtime-primitives.workspace = true
 
 [dev-dependencies]
 domain-runtime-primitives.workspace = true
@@ -51,6 +52,7 @@ std = [
     "sp-runtime/std",
     "sp-trie/std",
     "sp-subspace-mmr/std",
+    "subspace-runtime-primitives/std",
 ]
 runtime-benchmarks = [
     "frame-benchmarking",

domains/pallets/messenger/Cargo.toml

@@ -25,9 +25,11 @@ use sp_trie::StorageProof;
 #[cfg(feature = "std")]
 use std::collections::BTreeSet;
 
-#[benchmarks]
+#[benchmarks(where <RuntimeCallFor<T> as sp_runtime::traits::Dispatchable>::RuntimeOrigin: From<crate::RawOrigin>)]
 mod benchmarks {
     use super::*;
+    use crate::RawOrigin as MessengerOrigin;
+    use frame_system::pallet_prelude::RuntimeCallFor;
 
     #[benchmark]
     fn initiate_channel() {
@@ -152,7 +154,7 @@ mod benchmarks {
         };
 
         #[extrinsic_call]
-        _(RawOrigin::None, xdm);
+        _(MessengerOrigin::ValidatedUnsigned, xdm);
 
         let post_channel =
             Channels::<T>::get(dst_chain_id, channel_id).expect("channel should exist");
@@ -222,7 +224,7 @@ mod benchmarks {
         };
 
         #[extrinsic_call]
-        _(RawOrigin::None, xdm);
+        _(MessengerOrigin::ValidatedUnsigned, xdm);
 
         let post_channel =
             Channels::<T>::get(dst_chain_id, channel_id).expect("channel should exist");