Skip to content

Cleanup Exception handling #8

Open
@jmax01

Description

@jmax01
  • Removed calls to printStackTrace()` and replace with proper logging calls.
  • Remove throws declarations if method doesn't throw the declared exceptions
  • Do not swallow exceptions without logging the stack trace and adding comment as to why the exception is being swallowed
  • Chain all exceptions
  • Do not explicitly throw Throwable, Exception, or RuntimeException
  • For phase 1 all new Throwable calls will be replaced with the following:
    • IllegalArgumentException Thrown when parameters are invalid. Message should contain the invalid parameter and, if possible, a message about valid values. If a non-nullable parameter is null an NPE may be thrown instead.
    • IllegalStateException Thrown when a value of an instance field is not valid for successful execution of a method.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions