test: use ThreadingHTTPServer for browser-facing test servers

Single-threaded http.server.HTTPServer blocks its only thread in
rfile.readline() on the first connection it accepts. Chrome (especially under
--site-per-process) opens speculative/preconnect sockets without immediately
sending a request, so the server can stall on an idle socket and never serve the
real page request — Page.navigate then hangs the full 60s and fails with
CommandExecutionTimeout (seen on Windows CI for the cross-origin OOPIF test).
Switch every browser-facing test server to ThreadingHTTPServer so each
connection gets its own thread and idle/speculative sockets can't starve real
requests.

Author: thalissonvs

tests/integration/test_nested_oopif_integration.py

@@ -49,8 +49,8 @@ def __init__(self, *a, **kw):
 
         return H
 
-    srv_a = http.server.HTTPServer(('127.0.0.1', 0), _handler())
-    srv_b = http.server.HTTPServer(('127.0.0.1', 0), _handler())
+    srv_a = http.server.ThreadingHTTPServer(('127.0.0.1', 0), _handler())
+    srv_b = http.server.ThreadingHTTPServer(('127.0.0.1', 0), _handler())
     port_a = srv_a.server_address[1]
     port_b = srv_b.server_address[1]
 

tests/integration/test_tab_io_integration.py

@@ -1,6 +1,6 @@
 """Real-Chrome integration tests for Tab I/O over a local HTTP server.
 
-A throwaway ``HTTPServer`` serves a small page wired to external assets (CSS with
+A throwaway ``ThreadingHTTPServer`` serves a small page wired to external assets (CSS with
 a ``url()`` background, JS and images) plus a downloadable attachment. Against it
 we exercise the heavy I/O paths that need a real origin and real network
 fetches: ``save_bundle`` (both rewrite and inline modes), ``expect_download``
@@ -16,7 +16,7 @@
 import socket
 import threading
 import zipfile
-from http.server import BaseHTTPRequestHandler, HTTPServer
+from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
 from pathlib import Path
 
 import pytest
@@ -89,7 +89,7 @@ def log_message(self, *args):
 
 def _serve(handler_cls):
     port = _find_free_port()
-    server = HTTPServer(('127.0.0.1', port), handler_cls)
+    server = ThreadingHTTPServer(('127.0.0.1', port), handler_cls)
     thread = threading.Thread(target=server.serve_forever, daemon=True)
     thread.start()
     return server, thread, f'http://127.0.0.1:{port}'

tests/integration/test_tab_request_integration.py

@@ -11,7 +11,7 @@
 import json
 import socket
 import threading
-from http.server import BaseHTTPRequestHandler, HTTPServer
+from http.server import BaseHTTPRequestHandler, ThreadingHTTPServer
 from urllib.parse import parse_qs, urlparse
 
 import pytest
@@ -170,7 +170,7 @@ def log_message(self, *args):
 @pytest_asyncio.fixture
 async def request_tab(ci_chrome_options):
     port = _find_free_port()
-    server = HTTPServer(('127.0.0.1', port), _RequestHandler)
+    server = ThreadingHTTPServer(('127.0.0.1', port), _RequestHandler)
     thread = threading.Thread(target=server.serve_forever, daemon=True)
     thread.start()
     base = f'http://127.0.0.1:{port}'

tests/integration/test_worker_user_agent_integration.py

@@ -55,7 +55,7 @@ class _Handler(_SilentHandler):
         def __init__(self, *args, **kwargs):
             super().__init__(*args, directory=str(PAGES_DIR), **kwargs)
 
-    server = http.server.HTTPServer(('127.0.0.1', 0), _Handler)
+    server = http.server.ThreadingHTTPServer(('127.0.0.1', 0), _Handler)
     port = server.server_address[1]
     threading.Thread(target=server.serve_forever, daemon=True).start()
     _wait_for_server('127.0.0.1', port)