go_to always navigates directly

Author: dean985

pydoll/browser/tab.py

@@ -894,8 +894,6 @@ async def go_to(self, url: str, timeout: int = 300):
         """
         Navigate to URL and wait for loading to complete.
 
-        Refreshes if URL matches current page.
-
         Args:
             url: Target URL to navigate to.
             timeout: Maximum seconds to wait for page load (default 300).
@@ -905,14 +903,8 @@ async def go_to(self, url: str, timeout: int = 300):
             PageLoadTimeout: If page doesn't finish loading within timeout.
         """
         logger.info(f'Navigating to URL: {url} (timeout={timeout}s)')
-        if await self._refresh_if_url_not_changed(url, timeout):
-            logger.debug('URL matches current page; refreshed with navigation')
-            return
-
         async with self._wait_page_load(timeout=timeout):
-            response: NavigateResponse = await self._execute_command(
-                PageCommands.navigate(url)
-            )
+            response: NavigateResponse = await self._execute_command(PageCommands.navigate(url))
             error_text = response['result'].get('errorText')
             if error_text:
                 raise NavigationError(url, error_text)
@@ -1829,36 +1821,6 @@ def _get_evaluate_command(
             serialization_options=serialization_options,
         )
 
-    async def _refresh_if_url_not_changed(
-        self, url: str, timeout: int = 300
-    ) -> bool:
-        """Navigate to URL if it matches the current page.
-
-        Uses Page.navigate instead of Page.reload so that navigation
-        errors (e.g., DNS failures) are detected via errorText.
-
-        Args:
-            url: URL to compare against the current page.
-            timeout: Maximum seconds to wait for page load.
-
-        Returns:
-            True if the URL matched and a navigate-refresh was performed.
-
-        Raises:
-            NavigationError: If the navigation fails.
-        """
-        current_url = await self.current_url
-        if current_url == url:
-            async with self._wait_page_load(timeout=timeout):
-                response: NavigateResponse = await self._execute_command(
-                    PageCommands.navigate(url)
-                )
-                error_text = response['result'].get('errorText')
-                if error_text:
-                    raise NavigationError(url, error_text)
-            return True
-        return False
-
     @staticmethod
     def _validate_argument_error(response: EvaluateResponse) -> None:
         """

tests/test_browser/test_browser_tab.py

@@ -389,7 +389,6 @@ class TestTabNavigation:
     async def test_go_to_new_url(self, tab):
         """Test navigating to a new URL."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://old-url.com'}}},  # current_url
             {'result': {}},  # Page.enable
             {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
@@ -403,15 +402,14 @@ async def fire_callback(event_name, callback, temporary=False):
 
         await tab.go_to('https://example.com')
 
-        assert tab._connection_handler.execute_command.call_count == 4
+        assert tab._connection_handler.execute_command.call_count == 3
 
     @pytest.mark.asyncio
     async def test_go_to_navigation_error(self, tab):
         """Test that navigation errors raise NavigationError."""
         from pydoll.exceptions import NavigationError
 
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://old-url.com'}}},  # current_url
             {'result': {}},  # Page.enable
             {'result': {'frameId': 'f', 'errorText': 'net::ERR_NAME_NOT_RESOLVED'}},
             {'result': {}},  # Page.disable
@@ -431,11 +429,10 @@ async def fire_callback(event_name, callback, temporary=False):
 
     @pytest.mark.asyncio
     async def test_go_to_same_url(self, tab):
-        """Test navigating to the same URL (should refresh)."""
+        """Test navigating to the same URL works the same as a new URL."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://example.com'}}},  # current_url
             {'result': {}},  # Page.enable
-            {'result': {}},  # refresh command
+            {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
         ]
 
@@ -447,13 +444,12 @@ async def fire_callback(event_name, callback, temporary=False):
 
         await tab.go_to('https://example.com')
 
-        assert tab._connection_handler.execute_command.call_count == 4
+        assert tab._connection_handler.execute_command.call_count == 3
 
     @pytest.mark.asyncio
     async def test_go_to_timeout(self, tab):
         """Test navigation timeout."""
         tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://old-url.com'}}},  # current_url
             {'result': {}},  # Page.enable
             {'result': {'frameId': 'frame-id'}},  # navigate command
             {'result': {}},  # Page.disable
@@ -1851,38 +1847,6 @@ async def fire_callback(event_name, callback, temporary=False):
 
         assert tab._page_events_enabled is False
 
-    @pytest.mark.asyncio
-    async def test_refresh_if_url_not_changed_same_url(self, tab):
-        """Test _refresh_if_url_not_changed with same URL."""
-        tab._connection_handler.execute_command.side_effect = [
-            {'result': {'result': {'value': 'https://example.com'}}},  # current_url call
-            {'result': {}},  # Page.enable
-            {'result': {}},  # refresh call
-            {'result': {}},  # Page.disable
-        ]
-
-        async def fire_callback(event_name, callback, temporary=False):
-            callback({'method': event_name, 'params': {}})
-            return 1
-
-        tab._connection_handler.register_callback = AsyncMock(side_effect=fire_callback)
-
-        result = await tab._refresh_if_url_not_changed('https://example.com')
-
-        assert result is True
-        assert tab._connection_handler.execute_command.call_count == 4
-
-    @pytest.mark.asyncio
-    async def test_refresh_if_url_not_changed_different_url(self, tab):
-        """Test _refresh_if_url_not_changed with different URL."""
-        tab._connection_handler.execute_command.return_value = {
-            'result': {'result': {'value': 'https://different.com'}}
-        }
-        
-        result = await tab._refresh_if_url_not_changed('https://example.com')
-        
-        assert result is False
-        assert_mock_called_at_least_once(tab._connection_handler)
 
 
 class TestTabRequestManagement: