Skip to content

Don't use /tmp for disk attach  #3485

@qiankehan

Description

@qiankehan

Since qemu v5.2.0-rc0~110^2~1 util: give a specific error message when O_DIRECT doesn't work, it will report error when try to live attach file disk source from /tmp:

internal error: unable to execute QEMU command 'blockdev-add': Could not open '/tmp/disk-raw': filesystem does not support O_DIRECT

It seems some disk sources still use /tmp:

libvirt/tests/src/virsh_cmd/domain/virsh_detach_device.py:30:    def create_device_file(device_source="/tmp/attach.img"):

Here is why tmpfs cannot support O_DIRECT: https://lists.archive.carbon60.com/linux/kernel/720702

@chunfuwen @Yingshun @dzhengfy

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions