Skip to content

Skipped nodes are reported as failures when using --skip-not-compiled flag #80

@morgan-dgk

Description

@morgan-dgk

Expected Behavior

Nodes which are skipped should not be reported as failures in the report file generated when using the --skip-not-compiled flag.

Actual Behavior

Nodes which are skipped using the --skip-not-compiled flag are reported as failures in the report file generated. This behaviour is potentially confusing as it is possible for the CLI to report a successful run while the failed_node_ids array is non-empty in the report file.

Motivation / Use case for changing behaviour

Results returned by the CLI and in the report should be consistent. Perhaps a separate skipped_nodes array could be added to the report output.

I've had a poke around in the codebase, would be happy to have a go at a PR if this issue is accepted.

Specifications

Version: 0.8.0
Platform: macOS, Sierra 14

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions