Skip to content

Commit 576af35

Browse files
committed
Fix mypy type failure in tests
Use type narrowing approach, asserting on type before using a method with the more specific input type: https://mypy.readthedocs.io/en/stable/type_narrowing.html#type-narrowing-expressions
1 parent 6e20f97 commit 576af35

1 file changed

Lines changed: 6 additions & 8 deletions

File tree

tests/test_conftest.py

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,9 @@ def test_pyfunc_model_series_predict(
3838
model_output_series: pd.Series,
3939
):
4040
"""PyFunc model with Series return type should predict correct values."""
41-
42-
pd.testing.assert_series_equal(
43-
model_output_series, pyfunc_model_series.predict(model_input)
44-
)
41+
output = pyfunc_model_series.predict(model_input)
42+
assert isinstance(output, pd.Series)
43+
pd.testing.assert_series_equal(model_output_series, output)
4544

4645

4746
class TestDataFramePyFuncModel:
@@ -55,10 +54,9 @@ def test_pyfunc_model_dataframe_predict(
5554
model_output_dataframe: pd.DataFrame,
5655
):
5756
"""PyFunc model with DataFrame return type should predict correct values."""
58-
59-
pd.testing.assert_frame_equal(
60-
model_output_dataframe, pyfunc_model_dataframe.predict(model_input)
61-
)
57+
output = pyfunc_model_dataframe.predict(model_input)
58+
assert isinstance(output, pd.DataFrame)
59+
pd.testing.assert_frame_equal(model_output_dataframe, output)
6260

6361

6462
class TestNaNNDArrayPyFuncModel:

0 commit comments

Comments
 (0)