From 04ca9c9be7a696cc694a0b53d004c4b0bf90541d Mon Sep 17 00:00:00 2001 From: Vishal Chauhan <40782713+vish0012@users.noreply.github.com> Date: Fri, 8 May 2026 09:30:27 +0900 Subject: [PATCH] fix(clang-tidy): re-enable bugprone-unused-return-value Signed-off-by: Vishal Chauhan <40782713+vish0012@users.noreply.github.com> --- .clang-tidy-ci | 3 +-- .../reader/traffic_reader/traffic_reader_service.cpp | 2 +- system/autoware_system_monitor/src/net_monitor/net_monitor.cpp | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.clang-tidy-ci b/.clang-tidy-ci index e34647139bb06..bfce1237e779b 100644 --- a/.clang-tidy-ci +++ b/.clang-tidy-ci @@ -18,8 +18,7 @@ Checks: " -bugprone-signed-char-misuse, -bugprone-switch-missing-default-case, -bugprone-unchecked-optional-access, - -bugprone-unused-local-non-trivial-variable, - -bugprone-unused-return-value" + -bugprone-unused-local-non-trivial-variable" WarningsAsErrors: "*" diff --git a/system/autoware_system_monitor/reader/traffic_reader/traffic_reader_service.cpp b/system/autoware_system_monitor/reader/traffic_reader/traffic_reader_service.cpp index a0f8e45f5adfc..7917b3c66a46d 100644 --- a/system/autoware_system_monitor/reader/traffic_reader/traffic_reader_service.cpp +++ b/system/autoware_system_monitor/reader/traffic_reader/traffic_reader_service.cpp @@ -80,7 +80,7 @@ void TrafficReaderService::run() // Accept a new connection boost::system::error_code error_code; - acceptor_->accept(*socket_, error_code); + error_code = acceptor_->accept(*socket_, error_code); if (error_code) { syslog(LOG_ERR, "Failed to accept new connection. %s\n", error_code.message().c_str()); diff --git a/system/autoware_system_monitor/src/net_monitor/net_monitor.cpp b/system/autoware_system_monitor/src/net_monitor/net_monitor.cpp index 859328ce33005..6eecbedb8535f 100644 --- a/system/autoware_system_monitor/src/net_monitor/net_monitor.cpp +++ b/system/autoware_system_monitor/src/net_monitor/net_monitor.cpp @@ -664,7 +664,7 @@ bool NetMonitor::connect_service() // Connect socket boost::system::error_code error_code; - socket_->connect(endpoint, error_code); + error_code = socket_->connect(endpoint, error_code); if (error_code) { RCLCPP_ERROR_ONCE(get_logger(), "Failed to connect socket. %s", error_code.message().c_str());