Skip to content
This repository was archived by the owner on Aug 18, 2021. It is now read-only.
This repository was archived by the owner on Aug 18, 2021. It is now read-only.

Workbench.{Service} doesn't call Initialize #155

Open
@bruno-brant

Description

@bruno-brant

Workbench seems to be responsible for calling Initialize on each service it provides, as it can be seen from the method GetRegisteredService:

https://github.com/Avanade/Liquid-Application-Framework/blob/8f03b94252db859c61992662bc7c84fced8fee64/src/Liquid.Base/WorkBench.cs#L93-L99

However, for some reason, there's a very similar method called GetService that doesn't call initialization, and that method is the one used by the public static properties like Telemetry, Repository, etc.

https://github.com/Avanade/Liquid-Application-Framework/blob/8f03b94252db859c61992662bc7c84fced8fee64/src/Liquid.Base/WorkBench.cs#L108-L118

This can lead to some bugs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcomplexity:lowThe complexity of the issue is lowsize:smallThe size of the issue is small

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions