This repository was archived by the owner on Aug 18, 2021. It is now read-only.
This repository was archived by the owner on Aug 18, 2021. It is now read-only.
Refactor AzureBlob #160
Open
Description
Class AzureBlob has some issues that need to be addressed in order to raise the bar.
AzureBlob.Container.set has major side effects
A property shouldn't have side effects or perform some deep computation. It also calls async methods it doesn't waits on:
Transform unreadable ternary into a proper switch-case
It forcefully creates a container
There's no flag to control whether CreateIfNotExistsAsync
is called in this method:
Remove succeeds even if the file doesn't exists
The method Remove
hurst the principle of least surprise by calling DeleteIfExists, meaning that callers won't know if some error happens.
HealthCheck is completely broken
More info on #165.