build: bump go and golangci (#241)

AvalancheGo recently bumped both of these versions -- we're behind on Go
and the version of golangci we use is ancient -- not even V2.

This PR bumps both of those and fixes the below linter error: 

- **QF1005**: Replaced `math.Pow(math.E, N)` -> `math.Exp(N)`

---------

Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
Co-authored-by: Arran Schlosberg <519948+ARR4N@users.noreply.github.com>

Author: JonathanOppenheimer

.github/workflows/lint.yml

@@ -33,9 +33,9 @@ jobs:
         with:
           go-version-file: "go.mod"
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
+        uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.64.8
+          version: v2.9.0
 
   yamllint:
     runs-on: ubuntu-latest

.golangci.yml

@@ -1,10 +1,31 @@
 # This file configures github.com/golangci/golangci-lint.
 
+version: "2"
+
 run:
-  timeout: 20m
   tests: true
 
+formatters:
+  enable:
+    - gci
+    - gofmt
+    - goimports
+  settings:
+    gci:
+      custom-order: true
+      sections:
+        - standard
+        - default
+        - prefix(github.com/ava-labs/strevm)
+        # The rest of these break developer expections, in increasing order of
+        # divergence, so are at the end to increase the chance of being seen.
+        - dot
+        - blank
+  exclusions:
+    generated: lax
+
 linters:
+  default: none
   enable:
     # Every available linter at the time of writing was considered (quickly) and
     # inclusion was liberal. Linters are good at detecting code smells, but if
@@ -13,16 +34,14 @@ linters:
     - containedctx
     - errcheck
     - forcetypeassert
-    - gci
     - gocheckcompilerdirectives
-    - gofmt
     - goheader
-    - goimports
     - gomodguard
+    - gocritic
+    - godoclint
     - gosec
     - govet
     - ineffassign
-    # TODO(arr4n): investigate ireturn
     - misspell
     - nakedret
     - nestif
@@ -38,68 +57,43 @@ linters:
     - thelper
     - tparallel
     - unconvert
-    - usestdlibvars
     - unused
+    - usestdlibvars
     - whitespace
-
-linters-settings:
-  gci:
-    custom-order: true
-    sections:
-      - standard
-      - default
-      - prefix(github.com/ava-labs/strevm)
-      # The rest of these break developer expections, in increasing order of
-      # divergence, so are at the end to increase the chance of being seen.
-      - dot
-      - blank
-  goheader:
-    template-path: .license-header
-
-  gomodguard:
-    blocked:
-      modules:
-        - github.com/ethereum/go-ethereum:
-            reason: "Use ava-labs/libevm instead"
-        - github.com/ava-labs/coreth:
-            reason: "Avoid dependency loop"
-        - github.com/ava-labs/subnet-evm:
-            reason: "Avoid dependency loop"
-  revive:
-    rules:
-      - name: unused-parameter
-        # Method parameters may be required by interfaces and forcing them to be
-        # named _ is of questionable benefit.
-        disabled: true
-      - name: exported
-        severity: error
-        disabled: false
-        exclude: [""]
-        arguments:
-          - "sayRepetitiveInsteadOfStutters"
-      - name: package-comments
-        severity: warning
-        disabled: false
-
-  testifylint:
-    enable-all: true
-    disable:
-      - require-error # Blanket usage of require over assert is an anti-pattern
-
-issues:
-  include:
-    # Many of the default exclusions are because, verbatim "Annoying issue",
-    # which defeats the point of a linter.
-    - EXC0002
-    - EXC0004
-    - EXC0005
-    - EXC0006
-    - EXC0007
-    - EXC0008
-    - EXC0009
-    - EXC0010
-    - EXC0011
-    - EXC0012
-    - EXC0013
-    - EXC0014
-    - EXC0015
+  settings:
+    goheader:
+      template-path: .license-header
+    gomodguard:
+      blocked:
+        modules:
+          - github.com/ethereum/go-ethereum:
+              reason: "Use ava-labs/libevm instead"
+          - github.com/ava-labs/avalanchego/graft/coreth:
+              reason: "Avoid dependency loop"
+          - github.com/ava-labs/avalanchego/graft/evm:
+              reason: "Avoid dependency loop"
+          - github.com/ava-labs/avalanchego/graft/subnet-evm:
+              reason: "Avoid dependency loop"
+    staticcheck:
+      checks:
+        - "all"
+        - "-QF1008" # Explicit embedded field selectors improve readability.
+    revive:
+      rules:
+        - name: unused-parameter
+          # Method parameters may be required by interfaces and forcing them to be
+          # named _ is of questionable benefit.
+          disabled: true
+        - name: exported
+          severity: error
+          disabled: false
+          exclude: [""]
+          arguments:
+            - "sayRepetitiveInsteadOfStutters"
+        - name: package-comments
+          severity: warning
+          disabled: false
+    testifylint:
+      enable-all: true
+      disable:
+        - require-error # Blanket usage of require over assert is an anti-pattern

blocks/blockstest/chain.go

@@ -1,10 +1,6 @@
 // Copyright (C) 2025-2026, Ava Labs, Inc. All rights reserved.
 // See the file LICENSE for licensing terms.
 
-// Package blockstest provides test helpers for constructing [Streaming
-// Asynchronous Execution] (SAE) blocks.
-//
-// [Streaming Asynchronous Execution]: https://github.com/avalanche-foundation/ACPs/tree/main/ACPs/194-streaming-asynchronous-execution
 package blockstest
 
 import (

blocks/time.go

@@ -21,7 +21,7 @@ func PreciseTime(hooks hook.Points, hdr *types.Header) time.Time {
 	return preciseTime(hdr, hooks.SubSecondBlockTime(hdr))
 }
 
-func preciseTime(hdr *types.Header, subSec time.Duration) time.Time {
+func preciseTime(hdr *types.Header, subSec time.Duration) time.Time { //nolint:staticcheck // subSec intentionally communicates that the value is < time.Second
 	return time.Unix(
 		int64(hdr.Time), //nolint:gosec // Won't overflow for a few millennia
 		subSec.Nanoseconds(),

go.mod

@@ -1,6 +1,6 @@
 module github.com/ava-labs/strevm
 
-go 1.24.12
+go 1.25.7
 
 tool github.com/go-task/task/v3/cmd/task
 

sae/rpc.go

@@ -324,7 +324,7 @@ type ethAPIBackend struct {
 
 var _ APIBackend = (*ethAPIBackend)(nil)
 
-func (b *ethAPIBackend) ChainDb() ethdb.Database {
+func (b *ethAPIBackend) ChainDb() ethdb.Database { //nolint:staticcheck // this name required by ethapi.Backend interface
 	return b.vm.db
 }
 

sae/rpc_receipts_test.go

@@ -29,7 +29,7 @@ func TestImmediateReceipts(t *testing.T) {
 	}
 	notBlocked := txs[0]
 
-	b := sut.runConsensusLoop(t, txs[:]...)
+	b := sut.runConsensusLoop(t, txs...)
 	sut.testRPC(ctx, t, rpcTest{
 		method: "eth_getTransactionReceipt",
 		args:   []any{notBlocked.Hash()},

sae/rpc_test.go

@@ -1127,11 +1127,11 @@ func TestDebugGetRawTransaction(t *testing.T) {
 	}...)
 }
 
-func (sut *SUT) testGetByHash(ctx context.Context, t *testing.T, want *types.Block) {
+func (s *SUT) testGetByHash(ctx context.Context, t *testing.T, want *types.Block) {
 	t.Helper()
 
-	testRPCGetter(ctx, t, "eth_getBlockByHash", sut.BlockByHash, want.Hash(), want)
-	sut.testRPC(ctx, t, []rpcTest{
+	testRPCGetter(ctx, t, "eth_getBlockByHash", s.BlockByHash, want.Hash(), want)
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getBlockByHash",
 			args:   []any{want.Hash(), false},
@@ -1159,7 +1159,7 @@ func (sut *SUT) testGetByHash(ctx context.Context, t *testing.T, want *types.Blo
 		marshaled, err := wantTx.MarshalBinary()
 		require.NoErrorf(t, err, "%T.MarshalBinary()", wantTx)
 
-		sut.testRPC(ctx, t, []rpcTest{
+		s.testRPC(ctx, t, []rpcTest{
 			{
 				method: "eth_getTransactionByHash",
 				args:   []any{wantTx.Hash()},
@@ -1184,7 +1184,7 @@ func (sut *SUT) testGetByHash(ctx context.Context, t *testing.T, want *types.Blo
 	}
 
 	outOfBoundsIndex := hexutil.Uint(len(want.Transactions()) + 1) //nolint:gosec // Known to not overflow
-	sut.testRPC(ctx, t, []rpcTest{
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getTransactionByBlockHashAndIndex",
 			args:   []any{want.Hash(), outOfBoundsIndex},
@@ -1198,10 +1198,10 @@ func (sut *SUT) testGetByHash(ctx context.Context, t *testing.T, want *types.Blo
 	}...)
 }
 
-func (sut *SUT) testGetByUnknownHash(ctx context.Context, t *testing.T) {
+func (s *SUT) testGetByUnknownHash(ctx context.Context, t *testing.T) {
 	t.Helper()
 
-	sut.testRPC(ctx, t, []rpcTest{
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getBlockByHash",
 			args:   []any{common.Hash{}, true},
@@ -1243,11 +1243,11 @@ func (sut *SUT) testGetByUnknownHash(ctx context.Context, t *testing.T) {
 // testGetByNumber accepts a block-number override to allow testing via named
 // blocks, e.g. [rpc.LatestBlockNumber], not only via the specific number
 // carried by the [types.Block].
-func (sut *SUT) testGetByNumber(ctx context.Context, t *testing.T, want *types.Block, n rpc.BlockNumber) {
+func (s *SUT) testGetByNumber(ctx context.Context, t *testing.T, want *types.Block, n rpc.BlockNumber) {
 	t.Helper()
-	testRPCGetter(ctx, t, "eth_getBlockByNumber", sut.BlockByNumber, big.NewInt(n.Int64()), want)
+	testRPCGetter(ctx, t, "eth_getBlockByNumber", s.BlockByNumber, big.NewInt(n.Int64()), want)
 
-	sut.testRPC(ctx, t, []rpcTest{
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getBlockByNumber",
 			args:   []any{n, false},
@@ -1275,7 +1275,7 @@ func (sut *SUT) testGetByNumber(ctx context.Context, t *testing.T, want *types.B
 		marshaled, err := wantTx.MarshalBinary()
 		require.NoErrorf(t, err, "%T.MarshalBinary()", wantTx)
 
-		sut.testRPC(ctx, t, []rpcTest{
+		s.testRPC(ctx, t, []rpcTest{
 			{
 				method: "eth_getTransactionByBlockNumberAndIndex",
 				args:   []any{n, txIdx},
@@ -1290,7 +1290,7 @@ func (sut *SUT) testGetByNumber(ctx context.Context, t *testing.T, want *types.B
 	}
 
 	outOfBoundsIndex := hexutil.Uint(len(want.Transactions()) + 1) //nolint:gosec // Known to not overflow
-	sut.testRPC(ctx, t, []rpcTest{
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getTransactionByBlockNumberAndIndex",
 			args:   []any{n, outOfBoundsIndex},
@@ -1304,11 +1304,11 @@ func (sut *SUT) testGetByNumber(ctx context.Context, t *testing.T, want *types.B
 	}...)
 }
 
-func (sut *SUT) testGetByUnknownNumber(ctx context.Context, t *testing.T) {
+func (s *SUT) testGetByUnknownNumber(ctx context.Context, t *testing.T) {
 	t.Helper()
 
 	const n rpc.BlockNumber = math.MaxInt64
-	sut.testRPC(ctx, t, []rpcTest{
+	s.testRPC(ctx, t, []rpcTest{
 		{
 			method: "eth_getBlockByNumber",
 			args:   []any{n, true},

saexec/saexec_test.go

@@ -511,7 +511,7 @@ func TestGasAccounting(t *testing.T) {
 			wantExecutedBy:  at(21, 30*gastime.TargetToExcessScaling, 10*gasPerTx),
 			wantExcessAfter: 3 * ((5 * gasPerTx /*T*/) * gastime.TargetToExcessScaling /* == K */),
 			// Excess is now 3·K so the price is e^3
-			wantPriceAfter: gas.Price(math.Floor(math.Pow(math.E, 3 /* <----- NB */))),
+			wantPriceAfter: gas.Price(math.Floor(math.Exp(3 /* <----- NB */))),
 		},
 		{
 			blockTime:       22, // no fast-forward
@@ -520,7 +520,7 @@ func TestGasAccounting(t *testing.T) {
 			targetAfter:     5 * gasPerTx,
 			wantExecutedBy:  at(21, 40*gastime.TargetToExcessScaling, 10*gasPerTx),
 			wantExcessAfter: 4 * ((5 * gasPerTx /*T*/) * gastime.TargetToExcessScaling /* == K */),
-			wantPriceAfter:  gas.Price(math.Floor(math.Pow(math.E, 4 /* <----- NB */))),
+			wantPriceAfter:  gas.Price(math.Floor(math.Exp(4 /* <----- NB */))),
 		},
 	}
 
@@ -652,6 +652,7 @@ func FuzzOpCodes(f *testing.F) {
 
 		// Ensure that the SUT [logging.Logger] remains of this type so >=WARN
 		// logs become failures.
+		//nolint:staticcheck
 		var logger *saetest.TBLogger = sut.logger
 		// Errors in execution (i.e. reverts) are fine, but we don't want them
 		// bubbling up any further.