refactor(gastime): remove hooks import#304
Open
alarso16 wants to merge 4 commits into
Open
Conversation
alarso16
force-pushed
the
alarso16/gastime-hook-imports
branch
from
f27436e to
e067216
Compare
alarso16
commented
Mar 30, 2026
| // MinimumGasConsumption MUST be used as the implementation for the respective | ||
| // method on [params.RulesHooks]. The concrete type implementing the hooks MUST | ||
| // propagate incoming and return arguments unchanged. | ||
| func MinimumGasConsumption(txLimit uint64) uint64 { |
Contributor
Author
There was a problem hiding this comment.
Out of scope - but I initially moved this and didn't even notice. What's the point of this function? It's unused
JonathanOppenheimer
approved these changes
Apr 3, 2026
Contributor
JonathanOppenheimer
left a comment
JonathanOppenheimer
left a comment
There was a problem hiding this comment.
Seems straightforward enough to me.
alarso16
force-pushed
the
alarso16/gastime-hook-imports
branch
from
310119b to
75ed043
Compare
powerslider
reviewed
Apr 14, 2026
Comment on lines
+51
to
+54
| var ( | ||
| errTargetToExcessScalingZero = errors.New("targetToExcessScaling must be non-zero") | ||
| errMinPriceZero = errors.New("minPrice must be non-zero") | ||
| ) |
Contributor
There was a problem hiding this comment.
I would move the var block at the top of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the hooks imports in gastime makes its implementation more intuitive, and not depend on block headers. The naming may now be somewhat overkill. The motivation is to be able to provide the gastime into
BuildBlockto add the minimum necessary data for state sync through this hook simply, rather than providing a custom type that takes in: