Remove dusk-plonk dependency & make crates lighter (#122)

* refactored kate-recovery to replace dp deps

* refactored kate package to replace dp

* updated benchmarks

* fixed features

* fixed tests

* deep cleaning

* more cleaning

* dedup & more cleaning

* add placeholders for removed error_type

* add log dependency and improve error handling in reconstruction

Author: ToufeeqP

.gitignore

@@ -1,3 +1,4 @@
 target
-kate/.DS_Store
+.gdb_history
 .DS_Store
+.vscode

.rustfmt.toml

@@ -7,4 +7,4 @@ match_block_trailing_comma = true
 # group_imports = "StdExternalCrate"
 use_field_init_shorthand = true
 edition = "2018"
-hard_tabs = true
+hard_tabs = true

Cargo.lock

@@ -37,7 +37,6 @@ criterion = { version = "0.4", default-features = false }
 serde = { version = "1.0.196", default-features = false, features = ["derive", "alloc"] }
 hex = { version = "0.4", default-features = false, features = ["alloc", "serde"] }
 serde_json = { version = "1", default-features = false }
-dusk-bytes = { version = "0.1.6", default-features = false }
 impl-serde = { version = "0.5.0", default-features = false }
 
 # Crypto
@@ -49,10 +48,7 @@ blake2b_simd = { version = "1.0.2", default-features = false }
 sha2 = { version = "0.10.7", default-features = false }
 sha3 = { version = "0.10.0", default-features = false }
 
-poly-multiproof = { git = "https://github.com/availproject/poly-multiproof", ref="494468b86ac8e16dca21d465d921990c578eaad3", default-features = false, features = ['ark-bls12-381', "blst"]}
-
-dusk-plonk = { git = "https://github.com/availproject/plonk.git", default-features = false, features = ["alloc"], tag = "v0.12.0-polygon-2" }
-
+poly-multiproof = { git = "https://github.com/availproject/poly-multiproof", ref="494468b86ac8e16dca21d465d921990c578eaad3", default-features = false, features = ["ark-bls12-381", "blst"]}
 hash-db = { version = "0.16.0",  default-features = false }
 
 # Others
@@ -69,10 +65,6 @@ sp-crypto-ec-utils = { git = "https://github.com/availproject/polkadot-sdk", tag
 [profile.dev.package]
 nalgebra = { opt-level = 3 }
 blst = { opt-level = 3 }
-dusk-bls12_381 = { opt-level = 3 }
-dusk-plonk = { opt-level = 3 }
-dusk-jubjub = { opt-level = 3 }
-dusk-bytes = { opt-level = 3 }
 rayon = { opt-level = 3 }
 rayon-core = { opt-level = 3 }
 poly-multiproof = { opt-level = 3 }

Cargo.toml

@@ -1,4 +1,4 @@
 # Data Availability Core
 
 # Dev Notes
-When changes are made make sure to run `build_test.sh`. This will check if everything works correctly under all feature permutations
+When changes are made make sure to run `build_test.sh`. This will check if everything works correctly under all feature permutations.

README.md

@@ -119,10 +119,10 @@ where
 		let extrinsics_root = self.extrinsics_root.as_ref();
 
 		f.debug_struct("Header")
-			.field("parent_hash", &HexDisplay(&parent_hash))
+			.field("parent_hash", &HexDisplay(parent_hash))
 			.field("number", &self.number)
-			.field("state_root", &HexDisplay(&state_root))
-			.field("extrinsics_root", &HexDisplay(&extrinsics_root))
+			.field("state_root", &HexDisplay(state_root))
+			.field("extrinsics_root", &HexDisplay(extrinsics_root))
 			.field("digest", &self.digest)
 			.field("extension", &self.extension)
 			.finish()

core/src/header/mod.rs

@@ -13,7 +13,6 @@ avail-core = { path = "../core", default-features = false }
 kate-recovery = { path = "recovery", default-features = false }
 
 # Crypto
-dusk-plonk = { workspace = true }
 poly-multiproof = { workspace = true, default-features = false, features = ["blst"] }
 
 # Parity & Substrate
@@ -26,7 +25,6 @@ derive_more.workspace = true
 static_assertions.workspace = true
 thiserror-no-std.workspace = true
 
-dusk-bytes = { workspace = true, optional = true }
 hex = { workspace = true }
 hex-literal.workspace = true
 log = { workspace = true, optional = true }
@@ -47,14 +45,12 @@ test-case.workspace = true
 
 [features]
 default = [ "std" ]
-alloc = [ "dusk-plonk/alloc", "nalgebra/alloc" ]
+alloc = [ "nalgebra/alloc" ]
 parallel = [ "criterion/rayon", "rayon" ]
 
 std = [
 	"avail-core/std",
 	"codec/std",
-	"dusk-bytes",
-	"dusk-plonk/std",
 	"kate-recovery/std",
 	"log",
 	"nalgebra/std",

kate/Cargo.toml

@@ -1,14 +1,11 @@
 use avail_core::{AppExtrinsic, AppId, BlockLengthColumns, BlockLengthRows, DataLookup};
 use criterion::{criterion_group, criterion_main, BenchmarkId, Criterion, Throughput};
-use dusk_plonk::prelude::BlsScalar;
-use kate::{
-	com::{Cell, *},
-	metrics::IgnoreMetrics,
-	Seed, Serializable as _,
-};
+use kate::gridgen::core::AsBytes;
+use kate::{com::build_proof, com::par_build_commitments, com::Cell, metrics::IgnoreMetrics, Seed};
 use kate_recovery::{
 	com::reconstruct_extrinsics,
 	commitments,
+	commons::ArkScalar,
 	data::{self, DataCell},
 	matrix::Position,
 	proof, testnet,
@@ -39,7 +36,7 @@ fn load_xts() -> Vec<Vec<AppIdData>> {
 	serde_json::from_str(XTS_JSON_SETS).expect("Autogenerated Json file .qed")
 }
 
-fn sample_cells_from_matrix(matrix: &DMatrix<BlsScalar>, columns: Option<&[u16]>) -> Vec<DataCell> {
+fn sample_cells_from_matrix(matrix: &DMatrix<ArkScalar>, columns: Option<&[u16]>) -> Vec<DataCell> {
 	fn random_indexes(length: usize, seed: Seed) -> Vec<usize> {
 		// choose random len/2 (unique) indexes
 		let mut idx = (0..length).collect::<Vec<_>>();
@@ -74,7 +71,7 @@ fn sample_cells_from_matrix(matrix: &DMatrix<BlsScalar>, columns: Option<&[u16]>
 					let position = Position::new(row_pos, col_idx);
 					debug_assert!(*row_idx < col_view.len());
 					let data = col_view[*row_idx].to_bytes();
-					DataCell::new(position, data)
+					DataCell::new(position, data.unwrap())
 				})
 				.collect::<Vec<_>>()
 		})
@@ -146,7 +143,11 @@ fn reconstruct(xts: &[AppExtrinsic]) {
 	}
 
 	let dims_cols: u32 = dims.cols().into();
-	let public_params = testnet::public_params(usize::try_from(dims_cols).unwrap());
+	// let public_params = testnet::public_params(usize::try_from(dims_cols).unwrap());
+	let public_params = testnet::multiproof_params(
+		usize::try_from(dims_cols).unwrap(),
+		usize::try_from(dims_cols).unwrap(),
+	);
 	for cell in random_cells(dims.cols(), dims.rows(), Percent::one()) {
 		let row: u32 = cell.row.into();
 
@@ -166,7 +167,7 @@ fn reconstruct(xts: &[AppExtrinsic]) {
 
 		let extended_dims = dims.try_into().unwrap();
 		let commitment = commitments::from_slice(&commitments).unwrap()[row as usize];
-		let verification = proof::verify(&public_params, extended_dims, &commitment, &cell);
+		let verification = proof::verify_v2(&public_params, extended_dims, &commitment, &cell);
 		assert!(verification.is_ok());
 		assert!(verification.unwrap());
 	}