Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts shouldn't hide assertion failures #1997

Open
Marsup opened this issue Dec 14, 2018 · 4 comments
Open

Timeouts shouldn't hide assertion failures #1997

Marsup opened this issue Dec 14, 2018 · 4 comments
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality scope:assertions scope:reporters

Comments

@Marsup
Copy link

Marsup commented Dec 14, 2018

Issuehunt badges

Prerequisites

I checked other issues and couldn't find something similar, although #1485 is slightly related and is genuinely both surprising and completely counter-intuitive to me, but I'm not going to start this debate again.

Description

Test timeouts are hiding failed assertions.

Test Source

test('foo', t => {
  t.is(1, 2);
  return new Promise(() => {
    function f() {
      setTimeout(f, 10);
    }
    f();
  });
});

Error Message & Stack Trace

✖ Exited because no new tests completed within the last 2000ms of inactivity

That's all there is, no trace of the assertion.

Command-Line Arguments

ava --timeout=2s

Environment

Node.js v10.14.1
linux 4.18.0-12-generic
1.0.0-rc.2
6.4.1

There is a $40.00 open bounty on this issue. Add more on Issuehunt.

@novemberborn
Copy link
Member

Agreed. This is ultimately a limitation of the reporters, though we currently don't send the results of individual assertions to the main process either. I'm adding the appropriate labels.

@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 15, 2019
@IssueHuntBot
Copy link

@IssueHunt has funded $40.00 to this issue.


@yagyadeep786
Copy link

I want to contribute and fix this bug.

@novemberborn
Copy link
Member

@yagyadeep786 by all means. I don’t know if this is still an issue though, you’ll want to verify that first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💵 Funded on Issuehunt This issue has been funded on Issuehunt enhancement new functionality scope:assertions scope:reporters
Projects
None yet
Development

No branches or pull requests

4 participants