full-analysis: Use versioned manifest and Pkg.resolve for

auto-instantiation

When `auto_instantiate` is enabled and no manifest file exists, JETLS
now creates a versioned manifest file (e.g., `Manifest-v1.12.toml`)
before running `Pkg.resolve()` and `Pkg.instantiate()`.

Author: aviatesk

CHANGELOG.md

@@ -18,11 +18,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ### Added
 
-- JETLS now automatically runs `Pkg.instantiate()` for packages that have not
-  been instantiated yet (e.g., freshly cloned repositories). This allows
-  full analysis to work immediately upon opening such packages. Note that this
-  will automatically create a `Manifest.toml` file when the package has not been
-  instantiated yet. This behavior is controlled by the `full_analysis.auto_instantiate`
+- JETLS now automatically runs `Pkg.resolve()` and `Pkg.instantiate()` for
+  packages that have not been instantiated yet (e.g., freshly cloned repositories).
+  This allows full analysis to work immediately upon opening such packages.
+  When no manifest file exists, JETLS first creates a
+  [versioned manifest](https://pkgdocs.julialang.org/v1/toml-files/#Different-Manifests-for-Different-Julia-versions)
+  (e.g., `Manifest-v1.12.toml`).
+  This behavior is controlled by the `full_analysis.auto_instantiate`
   configuration option (default: `true`). Set it to `false` to disable.
 - When `full_analysis.auto_instantiate` is disabled, JETLS now checks if the
   environment is instantiated and warns the user if not.

docs/src/configuration.md

@@ -65,11 +65,12 @@ debounce = 2.0  # Wait 2 seconds after save before analyzing
 - **Type**: boolean
 - **Default**: `true`
 
-When enabled, JETLS automatically runs `Pkg.instantiate()` for packages that have
-not been instantiated yet (e.g., freshly cloned repositories). This allows full
-analysis to work immediately upon opening such packages. Note that this will
-automatically create a `Manifest.toml` file when the package has not been
-instantiated yet.
+When enabled, JETLS automatically runs `Pkg.resolve()` and `Pkg.instantiate()` for
+packages that have not been instantiated yet (e.g., freshly cloned repositories).
+This allows full analysis to work immediately upon opening such packages.
+When no manifest file exists, JETLS first creates a
+[versioned manifest](https://pkgdocs.julialang.org/v1/toml-files/#Different-Manifests-for-Different-Julia-versions)
+(e.g., `Manifest-v1.12.toml`).
 
 ```toml
 [full_analysis]

src/analysis/full-analysis.jl

@@ -676,6 +676,14 @@ end
 function ensure_instantiated!(server::Server, env_path::String)
     if get_config(server.state.config_manager, :full_analysis, :auto_instantiate)
         try
+            manifest_name = "Manifest-v$(VERSION.major).$(VERSION.minor).toml"
+            manifest_path = joinpath(dirname(env_path), manifest_name)
+            if !isfile(manifest_path)
+                JETLS_DEV_MODE && @info "Touching versioned manifest file" env_path
+                touch(manifest_path)
+            end
+            JETLS_DEV_MODE && @info "Resolving package environment" env_path
+            Pkg.resolve()
             JETLS_DEV_MODE && @info "Instantiating package environment" env_path
             Pkg.instantiate()
         catch e