full-analysis: Refactor analysis entry lookup with server-initiated progress (#345)

Split analysis entry lookup into two phases to enable dedicated progress
reporting for environment instantiation and analysis.

Phase 1 (`lookup_analysis_entry`) performs a non-blocking check that returns:
- `AnalysisEntry` directly if no instantiation is needed (cached or no env)
- `InstantiationRequest` if instantiation is required
- `OutOfScope` if the file is out of analysis scope

Phase 2 (`do_instantiation` or `do_instantiation_with_progress`) performs
the actual instantiation when needed.

This design allows the server to issue separate progress tokens for
instantiation and analysis phases, providing users with earlier and
more accurate progress feedback. The `InstantiationProgressCaller` is
non-cancellable since instantiation cannot be cancelled, while
`AnalysisProgressCaller` remains cancellable.

Also consolidate the entry point: replace separate `request_analysis_on_open!`
and `request_analysis_on_save!` functions with a unified `request_analysis!`
that handles both cases via the `onsave` parameter.

Co-authored-by: Claude <noreply@anthropic.com>

Author: aviatesk

CHANGELOG.md

@@ -44,6 +44,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
   Revise assumes it's loaded from a REPL session. Revise is now a direct
   dependency that's conditionally loaded at compile time based on the
   `JETLS_DEV_MODE` flag.
+- Significantly refactored the full-analysis pipeline implementation. Modified
+  the full-analysis pipeline behavior to output more detailed logs when
+  `JETLS_DEV_MODE` is enabled.
 
 ## 2025-11-28
 

src/JETLS.jl

@@ -331,8 +331,10 @@ struct ResponseMessageDispatcher
 end
 function (dispatcher::ResponseMessageDispatcher)(server::Server, msg::Dict{Symbol,Any})
     (; cancel_flag, request_caller) = dispatcher
-    if request_caller isa RequestAnalysisCaller
-        handle_request_analysis_response(server, request_caller, cancel_flag)
+    if request_caller isa InstantiationProgressCaller
+        handle_instantiation_progress_response(server, request_caller)
+    elseif request_caller isa AnalysisProgressCaller
+        handle_analysis_progress_response(server, request_caller, cancel_flag)
     elseif request_caller isa ShowDocumentRequestCaller
         handle_show_document_response(server, msg, request_caller)
     elseif request_caller isa SetDocumentContentCaller

src/analysis/full-analysis.jl

@@ -50,7 +50,7 @@ function handle_DidOpenTextDocumentNotification(server::Server, msg::DidOpenText
     update_testsetinfos!(server, uri, fi)
     cache_saved_file_info!(server.state, uri, parsed_stream)
 
-    request_analysis_on_open!(server, uri)
+    request_analysis!(server, uri, #=onsave=#false)
 end
 
 function handle_DidChangeTextDocumentNotification(server::Server, msg::DidChangeTextDocumentNotification)
@@ -85,7 +85,7 @@ function handle_DidSaveTextDocumentNotification(server::Server, msg::DidSaveText
     end
     cache_saved_file_info!(server.state, uri, text)
 
-    request_analysis_on_save!(server, uri)
+    request_analysis!(server, uri, #=onsave=#true)
 end
 
 function handle_DidCloseTextDocumentNotification(server::Server, msg::DidCloseTextDocumentNotification)

src/document-synchronization.jl

@@ -260,7 +260,7 @@ function with_completion_request(
             else
                 JETLS.cache_file_info!(server.state, uri, 1, clean_code)
                 JETLS.cache_saved_file_info!(server.state, uri, clean_code)
-                JETLS.request_analysis!(server, uri; notify_diagnostics=false)
+                JETLS.request_analysis!(server, uri, #=onsave=#false; wait=true, notify_diagnostics=false)
             end
 
             for (i, pos) in enumerate(positions)

test/test_completions.jl

@@ -0,0 +1,60 @@
+module test_lookup_analysis_entry
+
+using Test
+using Pkg
+using JETLS
+using JETLS: lookup_analysis_entry, ScriptInEnvAnalysisEntry, entryenvpath
+using JETLS.URIs2: filepath2uri
+
+@testset "lookup_analysis_entry for docs" begin
+    mktempdir() do temp_root
+        proj_dir = joinpath(temp_root, "TestPkg")
+        mkpath(proj_dir)
+        env_path = joinpath(proj_dir, "Project.toml")
+        write(env_path, """
+            name = "TestPkg"
+            uuid = "12345678-1234-1234-1234-123456789012"
+            version = "0.1.0"
+            """)
+
+        src_dir = joinpath(proj_dir, "src")
+        docs_dir = joinpath(proj_dir, "docs")
+        mkpath(src_dir)
+        mkpath(docs_dir)
+        mkpath(joinpath(docs_dir, "src"))
+
+        write(joinpath(src_dir, "TestPkg.jl"), "module TestPkg end")
+        write(joinpath(docs_dir, "make.jl"), "# docs make script")
+
+        # Test docs with docs/Project.toml
+        let docs_env_path = joinpath(docs_dir, "Project.toml")
+            write(docs_env_path, """
+                [deps]
+                Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
+                """)
+
+            filepath = joinpath(docs_dir, "make.jl")
+            uri = filepath2uri(filepath)
+            server = Server()
+            server.state.root_path = proj_dir
+            entry = lookup_analysis_entry(server, uri)
+            @test entry isa ScriptInEnvAnalysisEntry
+            @test entryenvpath(entry) == docs_env_path
+        end
+
+        # Test docs without docs/Project.toml (falls back to root Project.toml)
+        let docs_env_path = joinpath(docs_dir, "Project.toml")
+            rm(docs_env_path; force=true)
+
+            filepath = joinpath(docs_dir, "make.jl")
+            uri = filepath2uri(filepath)
+            server = Server()
+            server.state.root_path = proj_dir
+            entry = lookup_analysis_entry(server, uri)
+            @test entry isa ScriptInEnvAnalysisEntry
+            @test entryenvpath(entry) == env_path
+        end
+    end
+end
+
+end # module test_lookup_analysis_entry

test/test_lookup_analysis_entry.jl

@@ -310,7 +310,7 @@ end
             withserver() do (; writereadmsg, id_counter, server)
                 JETLS.cache_file_info!(server.state, uri, 1, script)
                 JETLS.cache_saved_file_info!(server.state, uri, script)
-                JETLS.request_analysis!(server, uri; notify_diagnostics=false)
+                JETLS.request_analysis!(server, uri, #=onsave=#false; wait=true, notify_diagnostics=false)
 
                 id = id_counter[] += 1
                 (; raw_res) = writereadmsg(DocumentDiagnosticRequest(;

test/test_lowering_diagnostics.jl

@@ -14,7 +14,7 @@ function analyze_and_resolve(s::AbstractString; kwargs...)
         fileinfo = JETLS.cache_file_info!(state, uri, 1, text)
         JETLS.cache_saved_file_info!(state, uri, text)
         JETLS.start_analysis_workers!(server)
-        JETLS.request_analysis!(server, uri; notify_diagnostics=false)
+        JETLS.request_analysis!(server, uri, #=onsave=#false; wait=true, notify_diagnostics=false)
 
         (; mod, analyzer) = JETLS.get_context_info(state, uri, position)