wip: Improve type stabilities in JETLS

Author: aviatesk

.JETLSConfig.toml

@@ -15,6 +15,13 @@ match_type = "regex"
 severity = "off"
 path = "LSP/src/LSP.jl"
 
+[[diagnostic.patterns]]
+pattern = "no matching method found .*var\"AnonymousInterface.*"
+match_by = "message"
+match_type = "regex"
+severity = "off"
+path = "LSP/src/**/*.jl"
+
 # TODO [JuliaLowering]
 # Temporarily downgrade some known JuliaLowering issues to information level
 [[diagnostic.patterns]]

src/analysis/full-analysis.jl

@@ -39,7 +39,7 @@ function collect_search_uris(server::Server, uri::URI)
     elseif analysis_info isa OutOfScope && @isdefined(Revise)
         # TODO: This implementation should be revisited when Revise is integrated into full-analysis
         out_of_scope = analysis_info
-        pkgid = Base.PkgId(something(out_of_scope.module_context, Main))
+        pkgid = Base.PkgId(@something(out_of_scope.module_context, Main))
         if haskey(Revise.pkgdatas, pkgid)
             pkgdata = Revise.pkgdatas[pkgid]
             for file in Revise.srcfiles(pkgdata)
@@ -702,7 +702,7 @@ function analyze_package_with_revise(
             show_error_message(server, "Failed to load package $(pkgid.name): $(sprint(Base.showerror, e))")
             error(lazy"Package $(pkgid.name) is not loadable") # TODO
         finally
-            notify(activation_done)
+            isnothing(activation_done) || notify(activation_done)
         end
     end
 

src/app.jl

@@ -128,7 +128,7 @@ function (@main)(args::Vector{String})::Cint
                 return Cint(1)
             end
         elseif (m = match(r"^--socket=(\d+)$", arg); !isnothing(m))
-            socket_port = tryparse(Int, m.captures[1])
+            socket_port = tryparse(Int, m.captures[1]::AbstractString)
             @label check_socket_port
             if isnothing(socket_port)
                 @error "Invalid port number for --socket (must be a valid integer)"
@@ -144,7 +144,7 @@ function (@main)(args::Vector{String})::Cint
                 return Cint(1)
             end
         elseif (m = match(r"^--clientProcessId=(\d+)$", arg); !isnothing(m))
-            client_process_id = tryparse(Int, m.captures[1])
+            client_process_id = tryparse(Int, m.captures[1]::AbstractString)
             @label check_client_process_id
             if isnothing(client_process_id)
                 @error "Invalid process ID for --clientProcessId (must be a valid integer)"

src/cli-check.jl

@@ -54,7 +54,7 @@ function render_spinner(p::SpinnerProgress)
             return
         end
         frame = SPINNER_FRAMES[p.spinner_idx]
-        prefix = "$(frame) $(p.current_file)"
+        prefix::String = "$(frame) $(p.current_file)"
         term_width = displaysize(p.io)[2]
         if isempty(p.current_message)
             if length(prefix) > term_width - 1
@@ -64,7 +64,7 @@ function render_spinner(p::SpinnerProgress)
             p.last_line_length = length(prefix)
         else
             separator = ": "
-            message = p.current_message
+            message::String = p.current_message
             total_len = length(prefix) + length(separator) + length(message)
             if total_len > term_width - 1
                 available = term_width - 1 - length(prefix) - length(separator) - 1
@@ -98,8 +98,9 @@ end
 
 function stop_spinner!(p::SpinnerProgress)
     p.active = false
-    if p.spinner_task !== nothing
-        wait(p.spinner_task)
+    spinner_task = p.spinner_task
+    if spinner_task !== nothing
+        wait(spinner_task)
         p.spinner_task = nothing
     end
     @lock p.lock clear_line(p)

src/completions.jl

@@ -490,11 +490,11 @@ function extract_param_text(p::JS.SyntaxTree)
     elseif k === JS.K"::"
         n = JS.numchildren(p)
         if n == 1
-            typ = JS.sourcetext(p[1])
+            typ = JS.sourcetext(p[1])::AbstractString
             return String("::" * typ)
         elseif n == 2
             name = @something extract_param_text(p[1]) return nothing
-            typ = JS.sourcetext(p[2])
+            typ = JS.sourcetext(p[2])::AbstractString
             return String(name * "::" * typ)
         else
             return nothing
@@ -575,18 +575,19 @@ function should_insert_spaces_around_equal(fi::FileInfo, ca::CallArgs)
         JS.kind(kwnode) === JS.K"kw" || continue
         has_equals += 1
         pos = offset_to_xy(fi, JS.first_byte(kwnode))
-        tok = token_at_offset(fi, pos)
+        tok = @something token_at_offset(fi, pos) continue
         while JS.is_whitespace(this(tok))
-            tok = next_tok(tok)
+            tok = @something next_tok(tok) @goto next
         end
         JS.kind(this(tok)) === JS.K"Identifier" || continue
-        tok = next_tok(tok)
+        tok = @something next_tok(tok) continue
         JS.is_whitespace(this(tok)) || continue
-        tok = next_tok(tok)
+        tok = @something next_tok(tok) continue
         JS.is_plain_equals(this(tok)) || continue
-        tok = next_tok(tok)
+        tok = @something next_tok(tok) continue
         JS.is_whitespace(this(tok)) || continue
         has_whitespaces += 1
+        @label next
     end
     return has_whitespaces ≥ has_equals - has_whitespaces
 end

src/utils/binding.jl

@@ -70,7 +70,10 @@ function jl_lower_for_scope_resolution(
     return _jl_lower_for_scope_resolution(ctx1, st0, st1; convert_closures)
 end
 
-function _jl_lower_for_scope_resolution(ctx1, st0, st1; convert_closures::Bool = false)
+function _jl_lower_for_scope_resolution(
+        ctx1::JL.MacroExpansionContext, st0::JS.SyntaxTree, st1::JS.SyntaxTree;
+        convert_closures::Bool = false
+    )
     ctx2, st2 = JL.expand_forms_2(ctx1, st1)
     ctx3, st3 = JL.resolve_scopes(ctx2, st2)
     convert_closures || return (; st0, st1, st2, st3, ctx3)

src/utils/server.jl

@@ -304,7 +304,7 @@ function get_context_info(state::ServerState, uri::URI, pos::Position; lookup_fu
 end
 
 get_context_module(::Nothing, ::URI, ::Position) = Main
-get_context_module(oos::OutOfScope, ::URI, ::Position) = something(oos.module_context, Main)
+get_context_module(oos::OutOfScope, ::URI, ::Position) = @something(oos.module_context, Main)
 function get_context_module(analysis_result::AnalysisResult, uri::URI, pos::Position)
     safi = @something analyzed_file_info(analysis_result, uri) return Main
     curline = Int(pos.line) + 1