fix bunch of type instabilities and logic errors

Author: aviatesk

src/analysis/full-analysis.jl

@@ -329,6 +329,9 @@ function lookup_analysis_entry(state::ServerState, uri::URI)
     end
 
     pkgname = find_pkg_name(env_path)
+    if isnothing(pkgname)
+        return ScriptInEnvAnalysisEntry(env_path, uri)
+    end
     filepath = uri2filepath(uri)::String # uri.scheme === "file"
     filekind, filedir = find_package_directory(filepath, env_path)
     if filekind === :src

src/config.jl

@@ -164,7 +164,7 @@ struct ConfigChange
     path::String
     old_val
     new_val
-    ConfigChange(path::String, @nospecialize(old_val), @nospecialize(new_val)) = new(path, old_val, new_val)
+    ConfigChange(path::AbstractString, @nospecialize(old_val), @nospecialize(new_val)) = new(path, old_val, new_val)
 end
 
 mutable struct ConfigChangeTracker

src/diagnostics.jl

@@ -345,9 +345,8 @@ function inference_error_report_code(@nospecialize report::JET.InferenceErrorRep
         else
             return INFERENCE_UNDEF_LOCAL_VAR_CODE
         end
-    else
-        return nothing
     end
+    error(lazy"Diagnostic code is not defined for this report: $report")
 end
 
 function jet_frame_to_location(frame)

src/did-change-watched-files.jl

@@ -118,7 +118,7 @@ end
 function handle_DidChangeWatchedFilesNotification(server::Server, msg::DidChangeWatchedFilesNotification)
     for change in msg.params.changes
         changed_path = uri2filepath(change.uri)
-        if is_config_file(changed_path)
+        if changed_path !== nothing && is_config_file(changed_path)
             handle_config_file_change!(server, changed_path, change.type)
         end
     end

src/signature-help.jl

@@ -262,7 +262,7 @@ end
 # active_arg is either an argument index, or :next (available pos. arg), or :none
 function make_siginfo(m::Method, ca::CallArgs, active_arg::Union{Int, Symbol};
                       postprocessor::LSPostProcessor = LSPostProcessor())
-    msig = get_sig_str(m, ca)
+    msig = @something get_sig_str(m, ca)
     msig = postprocessor(msig)
     mnode = JS.parsestmt(JL.SyntaxTree, msig; ignore_errors=true)
     label = String(msig)

src/types.jl

@@ -430,7 +430,7 @@ end
 
 is_static_setting(path::Symbol...) =
     is_static_setting(JETLSConfig, path...)
-
+is_static_setting(::Type{<:ConfigSection}) = false
 is_static_setting(::Type{T}, head::Symbol, rest::Symbol...) where {T<:ConfigSection} =
     is_static_setting(_unwrap_maybe(fieldtype(T, head)), rest...)
 

src/utils/ast.jl

@@ -26,9 +26,9 @@ function _without_kinds(st::JL.SyntaxTree, kinds::Tuple{Vararg{JS.Kind}})
 end
 
 function without_kinds(st::JL.SyntaxTree, kinds::Tuple{Vararg{JS.Kind}})
-    return JS.kind(st) in kinds ?
+    return (JS.kind(st) in kinds ?
         JL.@ast(JL.syntax_graph(st), st, [JS.K"TOMBSTONE"]) :
-        _without_kinds(st, kinds)[1]
+        _without_kinds(st, kinds)[1])::JL.SyntaxTree
 end
 
 function _remove_macrocalls(st::JL.SyntaxTree)

src/utils/general.jl

@@ -189,7 +189,7 @@ function install_instruction_message(app::AbstractString, instruction_url::Abstr
     """
 end
 
-function check_settings_message(setting_path::String...)
+function check_settings_message(setting_path::Symbol...)
     """
     This value is configured in the `$(join(setting_path, "."))`.
     Please check the settings.