full-analysis: cosmetic changes

Author: aviatesk

src/analysis/Interpreter.jl

@@ -65,8 +65,8 @@ function JET.analyze_from_definitions!(interp::LSInterpreter, config::JET.Toplev
     analyzer = JET.ToplevelAbstractAnalyzer(interp, JET.non_toplevel_concretized; refresh_local_cache = false)
     entrypoint = config.analyze_from_definitions
     res = JET.InterpretationState(interp).res
-    n = length(res.toplevel_signatures)
-    n == 0 && return
+    n_sigs = length(res.toplevel_signatures)
+    n_sigs == 0 && return
     cancellable_token = interp.request.cancellable_token
     if cancellable_token !== nothing
         if is_cancelled(cancellable_token.cancel_flag)
@@ -75,23 +75,23 @@ function JET.analyze_from_definitions!(interp::LSInterpreter, config::JET.Toplev
         send_progress(interp.server, cancellable_token.token,
             WorkDoneProgressReport(;
                 cancellable = true,
-                message = "0 / $n [signature analysis]",
+                message = "0 / $n_sigs [signature analysis]",
                 percentage = 50))
         yield_to_endpoint()
     end
-    next_interval = interval = 10 ^ max(round(Int, log10(n)) - 1, 0)
+    next_interval = interval = 10 ^ max(round(Int, log10(n_sigs)) - 1, 0)
     all_reports = JET.InferenceErrorReport[]
-    for i = 1:n
+    for i = 1:n_sigs
         if cancellable_token !== nothing
             if is_cancelled(cancellable_token.cancel_flag)
                 return
             end
             if i == next_interval
-                percentage = compute_percentage(i, n, 50) + 50
+                percentage = compute_percentage(i, n_sigs, 50) + 50
                 send_progress(interp.server, cancellable_token.token,
                     WorkDoneProgressReport(;
                         cancellable = true,
-                        message = "$i / $n [signature analysis]",
+                        message = "$i / $n_sigs [signature analysis]",
                         percentage))
                 yield_to_endpoint(0.01)
                 next_interval += interval

src/types.jl

@@ -108,13 +108,15 @@ end
 entryuri_impl(entry::ScriptAnalysisEntry) = entry.uri
 entryenvpath_impl(::ScriptAnalysisEntry) = nothing
 entrykind_impl(::ScriptAnalysisEntry) = "script"
+
 struct ScriptInEnvAnalysisEntry <: AnalysisEntry
     env_path::String
     uri::URI
 end
 entryuri_impl(entry::ScriptInEnvAnalysisEntry) = entry.uri
 entryenvpath_impl(entry::ScriptInEnvAnalysisEntry) = entry.env_path
 entrykind_impl(::ScriptInEnvAnalysisEntry) = "script in env"
+
 struct PackageSourceAnalysisEntry <: AnalysisEntry
     env_path::String
     pkgfileuri::URI
@@ -123,13 +125,13 @@ end
 entryuri_impl(entry::PackageSourceAnalysisEntry) = entry.pkgfileuri
 entryenvpath_impl(entry::PackageSourceAnalysisEntry) = entry.env_path
 entrykind_impl(::PackageSourceAnalysisEntry) = "pkg src"
-begin
-    local jetconfigs = Dict{Symbol,Any}(
+let jetconfigs = Dict{Symbol,Any}(
         :toplevel_logger => nothing,
         :analyze_from_definitions => true,
         :concretization_patterns => [:(x_)])
     entryjetconfigs_impl(::PackageSourceAnalysisEntry) = jetconfigs
 end
+
 struct PackageTestAnalysisEntry <: AnalysisEntry
     env_path::String
     runtestsuri::URI